dev-server: with SSR, stale component HMR update re-applied on every page load
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 75/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Stack de tecnologia
- angular, sass, typescript
- Domínio
- build-system, devtools
Direção de pesquisa
Start with packages/angular/build/src/tools/vite/middlewares/ssr-middleware.ts and plugins/setup-middlewares-plugin.ts, then compare their SSR request flow with the existing reset path in the Angular index HTML middleware. Reproduce the Sass partial case with SSR and verify both internal and external SSR paths clear stale component updates after a rendered document while component HMR still works.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Command
serve
Is this a regression?
- Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was
No response
Description
With SSR enabled, once a component has received an HMR update (Component update sent to client(s).), later changes that rebuild as a page reload never show in the browser for that component. Typical trigger: editing a Sass partial @used by the component stylesheet. Server output (/, main.js) is fresh; the browser keeps the old styles through any number of reloads, until the component's own file is saved again or ng serve restarts.
Cause, read from @angular/build 22.2.0 source:
src/builders/dev-server/vite/index.js: aComponentUpdateresult stores its content intemplateUpdates. The map is cleared only forResultKind.Full. The dev-server setsincrementalResults = true, so every rebuild after the first isIncrementaland never clears it.- The other clear path,
resetComponentUpdates, is passed only tocreateAngularIndexHtmlMiddleware(src/tools/vite/plugins/setup-middlewares-plugin.js). With SSR the SSR middleware answers the page request first, so the reset never runs. - On load, each component's HMR init fetches
/@ng/component?c=<id>&t=<now>.component-middleware.jsreturns the stored, now stale, update and the runtime applies it over the fresh bundle.
Without SSR the same steps work: the index HTML middleware resets the map on reload.
Expected: a page load after a later rebuild uses current styles. A fix is proposed at the end of this issue.
Minimal Reproduction
ng new hmr-repro-ssr --defaults --style=scss --ssrsrc/app/_tokens.scss:$gap: 10px;src/app/app.scss:@use "tokens"; h1 { margin-top: tokens.$gap; color: red; }src/app/app.html:<h1>Hello</h1>ng serve, open http://localhost:4200/. h1:margin-top: 10px, red.- In
app.scsschangeredtoblue. Log:Component update sent to client(s).h1 turns blue. Correct. - In
_tokens.scsschange10pxto40px. Log:Page reload sent to client(s). - Actual: h1 keeps
margin-top: 10px, also after a manual reload or a new navigation.curl http://localhost:4200/andcurl http://localhost:4200/main.jsboth carrymargin-top: 40px.curl 'http://localhost:4200/@ng/component?c=src%2Fapp%2Fapp.ts%40App&t=1'still returnsmargin-top: 10px.
- Save
app.scssagain, or restartng serve:40pxappears.
Control: the same steps in an app created with --ssr=false show 40px at step 8.
Workaround: NG_HMR_TEMPLATES=0 ng serve, or ng serve --no-hmr.
Exception or Error
Your Environment
Angular CLI : 22.2.0
Angular : 22.2.0
Node.js : 26.7.0
Package Manager : pnpm 10.30.2
Operating System : darwin arm64
@angular/build 22.2.0
@angular/cli 22.2.0
@angular/common 22.2.0
@angular/compiler 22.2.0
@angular/compiler-cli 22.2.0
@angular/core 22.2.0
@angular/platform-browser 22.2.0
@angular/platform-server 22.2.0
@angular/router 22.2.0
@angular/ssr 22.2.0
rxjs 7.8.2
typescript 6.0.3
Anything else relevant?
Not browser specific: the stale content is served by the dev server (tested in Chrome). First seen on 22.2.0-rc.0 in a larger SSR app, then confirmed on a clean 22.2.0 app with the steps above.
Proposed fix (verified locally)
CSR already resets the map on a page load: createAngularIndexHtmlMiddleware calls resetComponentUpdates() ("A request for the index indicates a full page reload request."). The SSR middlewares never receive that callback. Pass it to both SSR middleware factories and call it in the html:transform:pre hook, which runs once per rendered document:
--- a/packages/angular/build/src/tools/vite/middlewares/ssr-middleware.ts
+++ b/packages/angular/build/src/tools/vite/middlewares/ssr-middleware.ts
@@ -22,6 +22,7 @@
export function createAngularSsrInternalMiddleware(
server: ViteDevServer,
indexHtmlTransformer?: (content: string) => Promise<string>,
+ resetComponentUpdates?: () => void,
): Connect.NextHandleFunction {
let cachedAngularServerApp: ReturnType<typeof getOrCreateAngularServerApp> | undefined;
@@ -53,6 +54,9 @@
// Only Add the transform hook only if it's a different instance.
if (cachedAngularServerApp !== angularServerApp) {
angularServerApp.hooks.on('html:transform:pre', async ({ html, url }) => {
+ // A rendered document indicates a full page reload request.
+ resetComponentUpdates?.();
+
const processedHtml = await server.transformIndexHtml(url.pathname, html);
return indexHtmlTransformer?.(processedHtml) ?? processedHtml;
@@ -77,6 +81,7 @@
export async function createAngularSsrExternalMiddleware(
server: ViteDevServer,
indexHtmlTransformer?: (content: string) => Promise<string>,
+ resetComponentUpdates?: () => void,
): Promise<Connect.NextHandleFunction> {
let fallbackWarningShown = false;
let cachedAngularAppEngine: typeof SSRAngularAppEngine | undefined;
@@ -121,6 +126,7 @@
angularSsrInternalMiddleware ??= createAngularSsrInternalMiddleware(
server,
indexHtmlTransformer,
+ resetComponentUpdates,
);
angularSsrInternalMiddleware(req, res, next);
@@ -132,6 +138,9 @@
AngularAppEngine.ɵdisableAllowedHostsCheck = disableAllowedHostsCheck;
AngularAppEngine.ɵallowStaticRouteRender = true;
AngularAppEngine.ɵhooks.on('html:transform:pre', async ({ html, url }) => {
+ // A rendered document indicates a full page reload request.
+ resetComponentUpdates?.();
+
const processedHtml = await server.transformIndexHtml(url.pathname, html);
return indexHtmlTransformer?.(processedHtml) ?? processedHtml;
--- a/packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
+++ b/packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
@@ -117,13 +117,13 @@
if (ssrMode === ServerSsrMode.ExternalSsrMiddleware) {
patchBaseMiddleware(server.middlewares, server.config.base);
- middlewares.use(await createAngularSsrExternalMiddleware(server, indexHtmlTransformer));
+ middlewares.use(await createAngularSsrExternalMiddleware(server, indexHtmlTransformer, resetComponentUpdates));
return;
}
if (ssrMode === ServerSsrMode.InternalSsrMiddleware) {
- middlewares.use(createAngularSsrInternalMiddleware(server, indexHtmlTransformer));
+ middlewares.use(createAngularSsrInternalMiddleware(server, indexHtmlTransformer, resetComponentUpdates));
}
middlewares.use(angularHtmlFallbackMiddleware);
Verified by applying the equivalent change to the compiled @angular/build 22.2.0 in the reproduction above (external SSR middleware, default ng new --ssr server.ts):
- Before: after steps 6 and 7 plus one page request,
/@ng/componentstill returns the stored update (4839 bytes,margin-top: 10px). - After: the same request returns an empty body. The browser shows the new partial value after the reload, and component HMR still hot-swaps in place (step 6 applies without a page reload).
Not exercised: the internal SSR middleware path (the same change is applied there). The diff has not been run through prettier.
- Linguagem predominante
- TypeScript
- Estrelas
- 27k
- Forks
- 11.8k
- Merge médio
- 20h 47min
- PRs com merge (30d)
- 178
Preparar o ambiente
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de angular/angular-cli
-
area: @angular/build gemini-triaged
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 74/100
angular/angular-cli#33955 ·
Mantenedores costumam responder em até 1 dia
-
area: @angular/cli gemini-triaged
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
angular/angular-cli#33055 · 1 comentário · 3 reações ·
Mantenedores costumam responder em até 1 dia
-
area: @angular/build gemini-triaged
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 68/100
angular/angular-cli#34166 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
library builder: tslib is not added to the output package.jsonTalvez já em andamento @alan-agius4 assumiu há 5 dias. Abertaangular/build:library area: @angular/build gemini-triaged
angular/angular-cli#34131 · 1 responsável ·
Mantenedores costumam responder em até 1 dia
-
library builder: a name re-exported through two "export *" paths is dropped from the bundleTalvez já em andamento @alan-agius4 assumiu há 5 dias. Abertaangular/build:library area: @angular/build gemini-triaged
angular/angular-cli#34130 · 1 responsável ·
Mantenedores costumam responder em até 1 dia
Todas as issues de angular/angular-cli
Issues semelhantes
-
ADD openalgoAbertatemplate
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
Mantenedores costumam responder em até 1 dia
-
factory-active factory-automatic task-bug-reproduction-success task-identify-harness-labels-done task-identify-issue-type-done
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 90/100
vercel/ai#21528 · 3 comentários ·
Mantenedores costumam responder em até 1 dia
-
bug Needs: Triage :mag:
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
microsoft/fluentui-contrib#671 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 88/100
sveltejs/acorn-typescript#150 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100