useSyncExternalStore loops during hydration when getServerSnapshot differs from getSnapshot (flushPending exceeded 50 iterations)

Fechada
  • Algo errado?
#79 0 comentários 1 reação 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
react, typescript, vite
Domínio
frontend, testing

Direção de pesquisa

Start with packages/redact/src/dom/dispatcher.ts around the cited lines 331–348 and trace how hydration state affects useSyncExternalStore snapshots and scheduled updates. Compare the reproduction's Redact and React runs, then inspect nearby hydration tests or add a focused regression case. Done means hydration settles without the iteration error and reaches the client snapshot, matching React's two renders.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

🤖 Issue drafted with Claude Code. Reproduced and verified before posting.

Version: @tanstack/redact 0.2.1 (also 0.2.0). Baseline: react/react-dom 19.3.1.

Hydrating a component whose getServerSnapshot differs from getSnapshot never settles: Redact re-renders it 50 times, then hydrateRoot throws flushPending exceeded 50 iterations — suspected infinite update loop. (a bare Error in production). React renders it twice.

This is the "still hydrating?" idiom used by Headless UI 2.x (useServerHandoffComplete, behind Popover, Dialog, Transition…), so any page with a Headless UI component hits it.

Reproduction

npm i @tanstack/[email protected] react@19 react-dom@19 jsdom, then node repro.mjs redact / node repro.mjs react:

// repro.mjs
import { JSDOM } from "jsdom"
const { window } = new JSDOM("<!doctype html><div id=root></div>")
Object.assign(globalThis, { window, document: window.document, HTMLElement: window.HTMLElement, Node: window.Node })

const redact = process.argv[2] === "redact"
const R = await import(redact ? "@tanstack/redact" : "react")
const { renderToString } = await import(redact ? "@tanstack/redact/server" : "react-dom/server")
const { hydrateRoot } = await import(redact ? "@tanstack/redact/dom-client" : "react-dom/client")

let renders = 0
function App() {
  const isServer = R.useSyncExternalStore(() => () => {}, () => false, () => true)
  renders++
  return R.createElement("p", null, isServer ? "server" : "client")
}

const root = document.getElementById("root")
root.innerHTML = renderToString(R.createElement(App))
renders = 0
try {
  hydrateRoot(root, R.createElement(App))
} catch (error) {
  console.log("hydrateRoot threw:", error.message || "Error")
}
setTimeout(() => console.log({ renders, text: root.textContent }), 100)
Renders hydrateRoot throws Final text
React 19.3.1 2 no client
Redact 0.2.1 52 yes client

Same result in Chromium with a Vite build (redact() plugin, Redact on server and client).

Likely cause

In dispatcher.ts#L331-L348, the render reads getServerSnapshot() while root.h is set. The effect's check() compares it with getSnapshot(), finds a difference and calls scheduleUpdate. That update is flushed while the root is still marked as hydrating, so it reads the server snapshot again, and check() runs again (the inline subscribe changes every render). Logging inside the loop shows rendered=true client=false hydrating=true at every iteration.

React switches to getSnapshot() once the hydration render has committed, so its second render reads the client value and stops.

Impact

On a TanStack Start storefront using a Headless UI Popover, this adds ~150 ms of main-thread work per page load (4× CPU throttling) and reports an uncaught error, though the page ends up interactive.

Linguagem predominante
TypeScript
Estrelas
537
Forks
22
Merge médio
10h 27min
PRs com merge (30d)
40

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TanStack/redact

Todas as issues de TanStack/redact

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.