Gap e2e: witnesses owed for session-directory removal (review of #164: F2, F4, F5, F6)

Aberta
#169 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
javascript, node.js
Domínio
backend, testing

Direção de pesquisa

Read packages/oracles/oracle-gaps/paths.mjs and gap-report-oracle.property.test.mjs, then inspect the README section on session-directory cleanup. Map each F2, F4, F5 and F6 finding to the histories and observations that currently judge it. Done means the owed fault and stop witnesses cover the stated cases, the README explains when a directory is left behind, and stopped-run kill status comes from an observation.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Follow-ups from the review of #164 (#150's fix). Findings F4, F5 and F6 were not fixed in #164, and neither was a witness for F2(a). Each is a gap in what the gap report's end-to-end oracle judges. None is a known defect.

  • F2(a) and F4: no history makes a session directory's removal fail.
    • removeSession (packages/oracles/oracle-gaps/paths.mjs) catches the failure and leaves the directory for the next run. The catch keeps one done line: without it, a throw after the done line would reach uncaughtException and end the run a second time.
    • A mutant that removes the catch survives every history.
    • Witness owed: a test-only fault that makes the directory unremovable (under G43/R57). The removal then fails, the run ends with one done line and its own exit code, and the next run removes the directory.
    • The README does not say that a directory which cannot be removed is left. The witness should land with that sentence.
  • F2(b): the pid-reuse guard has no witness.
    • removeSession keeps the directory of a pid that a live process runs under. No history reuses a pid.
  • F5: each removal point is judged on only some paths.
    • The supervisor's removal is judged only by abort histories. A SIGINT or SIGTERM stop ends the child through process.exit, and the session's exit listener removes the directory first.
    • The exit listener is judged only on win32 (its hookStops histories), whose e2e jobs are non-blocking. POSIX's one unsupervised history stops at its note, before a session opens.
    • Witness owed: a POSIX unsupervised history that opens a session and is stopped. Today, a stop while the witness spins leaves the test's own child on unsupervised POSIX (C 2026-11-13).
  • F6: whether a stopped run was killed is read from the platform, not observed.
    • The killed field of the stopped observation (gap-report-oracle.property.test.mjs) treats every win32 abort as killed.
    • Once #79 adds a win32 supervisor, a supervised win32 abort must owe the removal of its child's directory. The field must then come from an observation, such as the .child pid beside the started marker, instead of the platform.

Owners:

  • #79 owns F6, and F5's win32 half once its supervisor lands.
  • Isaac, as the follow-up of #164, owns F2(a), F2(b), F4 and F5's POSIX half.

This issue was written by Isaac.

Linguagem predominante
JavaScript
Estrelas
5
Forks
1
Merge médio
11h 18min
PRs com merge (30d)
66

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TanStack/oracles

Todas as issues de TanStack/oracles

Issues semelhantes

Mais issues de JavaScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.