browser-db-sqlite-persistence: a way to queue app SQL behind the persistence's transactions on a shared database

Aberta
  • Algo errado?
#2,363 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
sqlite, typescript, wasm
Domínio
backend, database

Direção de pesquisa

Start by reading wa-sqlite-driver.ts and the package entry's exports field, then trace how BrowserWASQLiteDriver.transaction() queues work for a shared database handle. Decide which supported API shape safely queues application SQL behind persistence transactions; the issue lists exporting the driver, adding a persistence method, or documenting direct execution as off-limits. Done means the chosen approach prevents application statements from being rolled back unexpectedly.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

  • I've checked this against the latest DB packages (@tanstack/[email protected] from npm, and main at d054a772)

Describe the feature

I'd like a supported way to run my own SQL on the database handle that createBrowserWASQLitePersistence uses, queued behind the persistence's transactions.

Why

We keep app metadata in our own tables in the same OPFS database as our persisted collections: a sync cursor and an outbox of pending mutations. These tables are separate from the persistence's tables and never touch them. We send statements to them with database.execute() on the handle from openBrowserWASQLiteOPFSDatabase(), which is the handle we also pass to createBrowserWASQLitePersistence.

BrowserWASQLiteDriver.transaction() runs BEGIN IMMEDIATE, then several awaited execute calls, then COMMIT or ROLLBACK. Its queue (databaseExecutionStates, a WeakMap keyed by the database object) orders only the driver's own work. A statement we send to the same handle between that BEGIN IMMEDIATE and the COMMIT runs inside the driver's transaction, on the same connection. If the driver then rolls back, our write is rolled back with it, even though our execute() call already resolved.

For us this can silently drop rows from our outbox. We add rows to it and then set a "done" marker in a second statement. If a rollback lands between the two statements, the marker is kept and the rows are not. It needs a SQL error inside the driver's transaction, such as a full storage quota, so it's rare. Our callers can't detect it.

We found this by reading the driver code, not from a field report. We haven't built a standalone reproduction.

What we tried

  • Queueing behind the driver ourselves isn't possible. BrowserWASQLiteDriver is exported from wa-sqlite-driver.ts, but not from the package entry: the exports field lists only ., the wasm and the worker.
  • We could track the transaction ourselves. We could wrap the handle we pass in, watch for BEGIN IMMEDIATE, COMMIT and ROLLBACK, and hold our statements until no transaction is open. That depends on the driver's SQL text, which isn't a public contract.
  • A second connection is too heavy. It would mean a second worker and wasm instance per tab, plus lock contention on the file.

Possible shapes

Any of these would work for us:

  1. Export BrowserWASQLiteDriver from the package entry. A driver we construct on the same handle shares the WeakMap queue, so its run and transaction calls are ordered with the persistence's work.
  2. Add a method to the persistence, such as persistence.runExclusive(fn) or a driver accessor, that runs a callback in the same queue.
  3. Document the shared handle as off-limits for direct execute() calls, so other users don't run into this.

Option 1 looks smallest, since the queue already works per database object.

Context

The app is a local-first sync client. Each tab opens one OPFS database per data partition. Collections use persistedCollectionOptions with createBrowserWASQLitePersistence. Our own tables live next to the persistence's tables and use their own names.

Linguagem predominante
TypeScript
Estrelas
4k
Forks
280
Merge médio
1d 9h
PRs com merge (30d)
139

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TanStack/db

Todas as issues de TanStack/db

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.