Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

A live query's preload on an on-demand collection waits for any persisting optimistic transaction

Aberta
  • Algo errado?
#2,184 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
12/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
typescript
Domínio
databases

Direção de pesquisa

The hang comes from commitNextPendingTransactionBatch in packages/db/src/collection/state.ts, which holds accepted sync transactions while an optimistic one persists, and from whenSyncAccepted in packages/db/src/sync-receipt.ts. Start with the repro in packages/query-db-collection/tests/refetch-ordered-prefix-oracle.test.ts. Done means a focused Collection-lifecycle test where a new live query's preload settles during a held mutation, and the harness workaround is removed. The issue itself says whether this needs a design decision first.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Summary

While an optimistic transaction persists on an on-demand Query Collection, a new live query on that Collection does not become ready. Its preload() waits until the transaction settles. This happens even when the transaction touches rows the new query does not read.

Reproduction

Found while #2154 added an optimistic-hold dimension to packages/query-db-collection/tests/refetch-ordered-prefix-oracle.test.ts.

  1. Create an on-demand Query Collection with an onUpdate (or onDelete) handler that waits on a promise the test controls.
  2. Load some rows, then call collection.update(id, ...) on one loaded row. The handler now waits.
  3. Create a second live query on the same Collection, for example where id = <another id>, and call preload().
  4. The preload does not settle until the handler's promise resolves. Without step 2, it settles at once.

Seven variants all hang at step 3. They cover an update or a delete hold, the same row or another row, and a backend change first or not.

Why

  • commitNextPendingTransactionBatch holds every accepted sync transaction back while an optimistic transaction persists (packages/db/src/collection/state.ts).
  • Collection readiness and mutation-handler writes wait for acceptance (whenSyncAccepted, packages/db/src/sync-receipt.ts).
  • A loadSubset load settles only when its rows are visible, so a load during the hold waits for the transaction.

Is this intended?

Probably not as a product promise: a slow mutation (offline, slow server) delays every live query that opens during it. It is the same mechanism as #2169, where held sync rows hide an optimistic removal. It may need the same law decision: which observations may wait for a persisting transaction.

Suggested witness

A focused Collection-lifecycle witness: a held mutation, then a new live query's preload must settle. Then remove the harness workaround in the query-db refetch oracle, which today defers awaiting preload() until the hold's release.

This issue was written by Isaac.

Linguagem predominante
TypeScript
Estrelas
3.9k
Forks
272
Merge médio
22h 54min
PRs com merge (30d)
236

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TanStack/db

Todas as issues de TanStack/db

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.