Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Persisted Query Collection can enter error state when refetch supersedes a pending SQLite application

Fechada
  • Algo errado?
#1,990 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
sqlite, typescript
Domínio
databases, testing-qa

Direção de pesquisa

Start by tracing enqueueResultApplication, invalidatePendingResultApplication, and trackResultApplication through the persisted Query Collection and sync transaction code. Reproduce the interleaving with the described node:sqlite integration test, focusing on the result of commit(signal) and pending SQLite application. Done means the second refetch exposes value 3 without an application error or a stale value 1.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Versions
  • @tanstack/db 0.11.1
  • @tanstack/query-db-collection 1.3.2
  • @tanstack/expo-db-sqlite-persistence 0.2.26
  • @tanstack/react-db 0.5.1
Problem

A second refetch of a persisted Query Collection can leave an active collection in error when the previous query result has already committed a sync transaction but SQLite has not applied it yet. This happens during ordinary use, without cleanup or a session change.

The adapter logs:

[QueryCollection] Error applying query overlap: AbortError: Sync transaction was aborted before application
[Live Query Error] Source collection 'overlap' entered error state

The collection can retain the old row after both refetches settle.

Deterministic reproduction
  1. Create a persisted Query Collection with one row { id: 'row', value: 1 }, a QueryClient, and an Expo-SQLite-compatible database. Preload it.
  2. Decorate the database runAsync to await a deferred promise when a holdWrites flag is set. This delays SQLite application without delaying queryFn.
  3. Set holdWrites = true, change the server row to { id: 'row', value: 2 }, and call collection.utils.refetch().
  4. Wait until the query fetch is idle and its result has started applying to SQLite (the decorated runAsync has entered the wait).
  5. Change the server row to { id: 'row', value: 3 } and call collection.utils.refetch() again.
  6. Release the SQLite write; await both refetches.

Expected: value 3 is visible; no collection application error.

Actual: an AbortError is logged by trackResultApplication, and the visible row can remain value 1. The second query function did run, so this is not a fetch deduplication issue.

This also occurs when a mutation handler publishes an authoritative server row with writeUpsert while a query refresh is in flight, as in our XP award collection.

Likely cause

enqueueResultApplication calls invalidatePendingResultApplication for the previous result. That unconditionally aborts its controller. When its sync transaction has already been committed and is waiting for SQLite, aborting it removes it from the core pending queue. The newer transaction for the same row can depend on that queued transaction and gets invalidated too (SyncTransactionAbortedError).

I reproduced this in a real node:sqlite integration test. Keeping committed sync transactions alive until their SQLite application finishes, while still aborting pre-commit work, makes the test pass. A guard around cancellation after commit(signal) returns a pending application receipt is one possible fix. This is a suggested direction, not a claim that it covers all interleavings.

Linguagem predominante
TypeScript
Estrelas
3.9k
Forks
268
Merge médio
1d 4h
PRs com merge (30d)
178

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TanStack/db

Todas as issues de TanStack/db

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.