-permute and -dry-run gaps: seeds-only pass, custom words, resolver pool
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 35/100
- Tipo de issue
- Funcionalidade
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Stack de tecnologia
- go
- Domínio
- cli, networking
Direção de pesquisa
Read the relevant entry points in internal/cli/cli.go, wordlist.go, permute.go, and dryrun.go, then trace permutation generation through internal/candidates/candidates.go and internal/permute/permute.go. Start with docs/DEVELOPER_GUIDE.md and run go test ./... using only simulated or lab DNS. Done means all three gaps meet the acceptance criteria, including resolver pool estimates and preflight output.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Summary
Three smaller gaps in -permute and -dry-run.
1. -permute cannot run from -seeds alone; a permute-only pass needs a throwaway main scan
- Where:
internal/cli/cli.go:262,internal/cli/wordlist.go:56-76,internal/cli/permute.go:65-84 - What happens:
-seeds"implies -permute" (cli.go:262), but the permutation pass only runs after a main pass over the wordlist; omitting-wselects the bundled 5000-entry list (wordlist.go:58-62), and an empty-wfile is refused. Verified with the built binary:subenum -simulate -seed 1 -w empty.txt -seeds seeds.txt lab.exampleexits 1 withError: wordlist empty.txt has no valid entries. Issue search for "permute only", "permute-only", "skip the main", "without the main": no hits; #72 (the -permute feature) does not cover it. - Impact: The second-stage workflow #72 targets (earlier results in, alterations out) costs a full bundled-wordlist scan of the target each time (10,000 extra queries with the default types), or a hand-made one-line dummy wordlist that still queries that name.
- To see it: As above.
- Suggested fix: When
-seedsis given with an explicit "no wordlist" (-w ""already means "bundled", so a new value such as-w noneor a-permute-onlyflag), skip the main pass and runrunPermutationPasswithfoundempty and the seeds as the only input. Make-dry-runcount the permutation candidates in this mode, since they are known without a scan.
2. -permute uses a fixed 30-word list; the CLI cannot pass the custom words the library accepts
- Where:
internal/permute/permute.go:16-21,internal/candidates/candidates.go:164,pkg/subenum/subenum.go:449-458 - What happens:
candidates.Permutationsalways callspermute.Generate(rel, permute.Words, skip)(candidates.go:164), andpermute.Wordsis a hard-coded list of 30 environment/role names (permute.go:16-21). The public library already takes custom words (subenum.Permutations(seeds, words), nil = built-in, subenum.go:449-458), so the CLI is the only surface without the option. Labels the scan itself discovered (for examplepaymentsinpayments.example.com) are never combined with other seeds. Issue search for "permute-words", "permutation words", "custom words": no hits. - Impact: Permutation hit rates depend on an organisation's own naming (
-eu1,-k8s, product names); users who know them have to switch to an external alteration tool and lose subenum's guarded second pass. - Suggested fix: Add
-permute-words <file>(one word per line,#comments, same normalisation as wordlists), merged with the built-in list or replacing it (-permute-words-only, mirroring-takeover-providers-only), threaded throughcandidates.Permutations. Optionally add the distinct leftmost labels of the main pass's hits to the word set (capped). Record the words file in the resume input fingerprint, as the wordlist is, so a resumed permute pass rebuilds the same candidates.
3. -dry-run ignores the resolver pool: no per-resolver preflight, and -rate-per-resolver is not in the duration
- Where:
internal/cli/dryrun.go:40-76,internal/cli/dryrun.go:115-119,internal/cli/session.go:109-114,internal/cli/cli.go:268 - What happens:
loadInputsbuildss.in.poolfrom-rbeforedryRunruns (session.go:109-114), butdryRunnever reads it. The preflight goes only tof.dnsServer(dryrun.go:43, :70-71), and the duration estimate uses onlyf.rate(dryrun.go:65-68); with-r pool.txt -rate-per-resolver 20and no-rate, which the help explicitly allows ("-rate still caps the total (0 = unlimited)", cli.go:268), the plan printsduration not bounded by -rate (unlimited)(dryrun.go:118) although the scan is capped at 20 x pool size queries/s. - Impact: The users who most need a plan before a big run, those using a resolver pool for a large wordlist, get a duration line that says "unlimited" and learn only mid-scan that part of their pool times out or is benched. Lab users are unaffected.
- To see it: Reasoned from code (a live pool cannot be exercised hermetically here):
subenum -dry-run -r pool.txt -rate-per-resolver 20 -w big.txt example.comprints the unlimited duration line and one preflight line for 8.8.8.8:53. - Suggested fix: When
s.in.pool != nil, compute the effective rate asmin(rate, ratePerRes * pool.Size())(either term 0 meaning no bound) for the estimate, and say which flag bounds it. Add one preflight per pool member (one query each, the same kind of traffic the dry run already sends) and print a per-resolver ok/failed line. Keep the JSON plan in step (pool_preflightarray,rate_effective).
Acceptance criteria
- -permute cannot run from -seeds alone; a permute-only pass needs a throwaway main scan
- -permute uses a fixed 30-word list; the CLI cannot pass the custom words the library accepts
- -dry-run ignores the resolver pool: no per-resolver preflight, and -rate-per-resolver is not in the duration
Related: #72
Getting started
- Relevant files:
internal/cli/cli.go,internal/cli/wordlist.go,internal/cli/permute.go,internal/permute/permute.go,internal/candidates/candidates.go,pkg/subenum/subenum.go - How to run tests:
go test ./...(tests must stay hermetic: use-simulate, a lab zone orinternal/dnstest, never a live domain) - Related docs:
docs/DEVELOPER_GUIDE.md,docs/ARCHITECTURE.md
Filed by repo-audit/full-audit at 0f3b0b6. Severity: low. Effort: M. audit-key: enhancement|internal/cli/permute.go|permute-dryrun-gaps
- Linguagem predominante
- Go
- Estrelas
- 1
- Forks
- 1
- Merge médio
- 8h 3min
- PRs com merge (30d)
- 31
Preparar o ambiente
Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.
- Inclui um Dockerfile ou arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de TMHSDigital/subenum
-
Resumed -follow-records hits come back with source wordlistTalvez já em andamento @bfs2021 assumiu hoje. Abertaarea: cli bug good first issue severity: low
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 35/100
TMHSDigital/subenum#441 ·
Mantenedores costumam responder em até 1 dia
-
enhancement severity: low
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 55/100
TMHSDigital/subenum#416 ·
Mantenedores costumam responder em até 1 dia
-
community marketing priority: low
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 35/100
TMHSDigital/subenum#132 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
documentation marketing priority: medium
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 25/100
TMHSDigital/subenum#127 ·
Mantenedores costumam responder em até 1 dia
-
ci feature marketing priority: medium
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 35/100
TMHSDigital/subenum#126 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
Todas as issues de TMHSDigital/subenum
Issues semelhantes
-
add CLI flag to hide animationTalvez já em andamento @prdai assumiu hoje. Abertafeature request
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 60/100
ollama/ollama#19828 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
Expose session state keys on the Go todo and agent-mode providersTalvez já em andamento @gabisonia assumiu hoje. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
microsoft/agent-framework-go#1412 ·
Mantenedores costumam responder em até 1 dia
-
area:webapp bug finding
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
Mantenedores costumam responder em até 1 dia
-
flaky-test
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 88/100
Mantenedores costumam responder em até 1 dia
-
kind/cleanup
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
kubernetes-sigs/kueue#19279 ·
Mantenedores costumam responder em até 1 dia