Secret masking runs all lines under one 1 s regex budget, so large log indexes fail with a misleading error

Aberta
#347 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
74/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
node.js, typescript
Domínio
performance

Direção de pesquisa

Start with src/utils/ocr.ts and trace regexRanges, REGEX_BUDGET_MS, and the DEFAULT_SECRET_PATTERN; then read how maskSecrets is called from src/utils/bugReport.ts and the indexing paths named in the issue. Run the relevant tests with npm test, including the 50k-line masking case and a caller-supplied catastrophic regex. Done means default-pattern masking handles the specified input and custom regexes still stop at the budget.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

effort: small performance priority: medium

Summary

regexRanges runs every text in a single runInNewContext(REGEX_SCAN, { texts, query }, { timeout: REGEX_BUDGET_MS }) call with a 1,000 ms budget. Each text is scanned three times against the 8-alternative DEFAULT_SECRET_PATTERN. index_recording masks every log line in one call (up to 50,000 lines of up to 2,000 chars), and searchIndex masks every item again on each query. The budget therefore caps the total volume of text, not a pathological pattern.

Where

  • src/utils/ocr.ts:141, 166-182 (REGEX_BUDGET_MS, the single vm call at :173)
  • src/utils/bugReport.ts:124 (maskSecrets)
  • src/tools/indexRecording.ts:167, src/utils/recordingIndex.ts:419

Impact

A long recording with chatty logs can exceed 1 s on a slower machine. index_recording then fails, or search_recording fails on every query, with an error blaming nested quantifiers in "your" regex, although the pattern is the built-in secret pattern. The exact tipping size depends on line length and the machine and was not measured.

Suggested fix

Run the built-in DEFAULT_SECRET_PATTERN directly, without the vm budget, or chunk texts into batches that each get their own budget. Keep the shared budget only for caller-supplied regexes.

Acceptance criteria

  • Masking 50k synthetic 1 KB log lines with the default pattern does not throw.
  • A caller-supplied catastrophic regex is still stopped by the budget.

Getting started

  • Relevant files: src/utils/ocr.ts, src/utils/bugReport.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: S. audit-key: performance|src/utils/ocr.ts|regexRanges

Linguagem predominante
TypeScript
Estrelas
1
Forks
4
Merge médio
14h 8min
PRs com merge (30d)
48

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TMHSDigital/screencast-mcp

Todas as issues de TMHSDigital/screencast-mcp

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.