Decide (post-v5): fix/undo/sync command model and exit 0 when there is nothing to undo

Aberta
  • Algo errado?
#1,352 2 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
12/100
Tipo de issue
Refatoração
Clareza
Precisa de esclarecimento
Status de atividade
Ativa
Stack de tecnologia
cli, rust
Domínio
cli

Direção de pesquisa

This is a design decision, not a ready change: the maintainer must first settle the new command model and the exit codes for an empty project. Read the per-command table in #1088 and the tests the issue names (in_process_rollback_hosted.rs, mode_migration_vlt.rs, e2e_redirect_vlt_build.rs around L1185-1210). Done means a maintainer decision is recorded, and only then can the tests that pin exit 1 be updated.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

agent:needs-human agent:triaged arch-audit priority:p3 refactor ux

[agent] Split out of #1088. The maintainer's 2026-10-09 triage narrowed #1088's v5 scope to "a bare scan/get keeps the project's mode" (PR #1317). The other two questions from #1088 are not release requirements, so they are tracked here, without v5-blocker.

Q1, option 3: new command model (next major)

New Replaces
read-only scan today's scan --dry-run
fix [TARGET…] [--mode M] scan (write) and get
undo [TARGET…] rollback, remove and vendor --revert
sync apply, repair and scan --prune
check apply --check and vendor --check

The old verbs would stay as aliases for one major. This is blocked by the C11/C12 engine split (#843, #894). See #1088 for the full rationale (register C34).

Q2: "nothing to undo" exits differently per command (register C74)

On a project with no patch state (a fresh project, or one that a full rollback just emptied), list, apply and vendor --revert exit 0, but rollback and repair exit 1 (manifest_not_found, and rollback uses the legacy {"status":"error","error":"Manifest not found"} shape). So a second rollback exits 1. #1088 has the per-command table and repro.

The proposal (#1088 option A):

  • rollback on an empty project returns status: success with zero counts.
  • repair on an empty project matches apply (noManifest, exit 0).
  • remove <target> with no match keeps exit 1 (not_found).

Tests that pin today's exit 1: in_process_rollback_hosted.rs, mode_migration_vlt.rs, e2e_redirect_vlt_build.rs (L1185-1210) and the covgap rollback/repair suites.

Both parts need a maintainer decision before implementation.

Linguagem predominante
Rust
Estrelas
9
Forks
2
Merge médio
20h 47min
PRs com merge (30d)
681

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de SocketDev/socket-patch

Todas as issues de SocketDev/socket-patch

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.