Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Attachments are not synced on player creation

Aberta
  • Algo errado?
#261 0 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Esta issue ainda não foi avaliada.

Descrição

1.21.x bug
Minecraft version

1.21.1

Describe the bug

When a new player is created, e.g. upon join, dimension change, or respawn, attachments are not synced. Attachments do sync properly when setAttached/removeAttached is called.

Steps to reproduce
  1. Create a fabric mod with the following mod initializer
@SuppressWarnings("UnstableApiUsage")
public class BugDemo implements ModInitializer {
	public static final String MOD_ID = "bugdemo";

	public static final Logger LOGGER = LoggerFactory.getLogger(MOD_ID);

	public static final AttachmentType<Unit> TEST = AttachmentRegistry.create(ResourceLocation.fromNamespaceAndPath(MOD_ID, "test"), builder -> builder
			.persistent(Unit.CODEC)
			.syncWith(StreamCodec.unit(Unit.INSTANCE), AttachmentSyncPredicate.targetOnly())
			.copyOnDeath()
	);

	@Override
	public void onInitialize() {
		UseItemCallback.EVENT.register((player, world, hand) -> {
			var stack = player.getItemInHand(hand);

			if (stack.is(Items.BLAZE_ROD)) {
				if (world.isClientSide()) return InteractionResultHolder.success(stack);

				player.setAttached(TEST, Unit.INSTANCE);

				return InteractionResultHolder.success(stack);
			}

			if (stack.is(Items.STICK)) {
                LOGGER.info(
                        "{} {} attachment",
                        world.isClientSide() ? "client" : "server",
                        player.hasAttached(TEST) ? "has" : "does not have"
                );
                return InteractionResultHolder.success(stack);
            }

			return InteractionResultHolder.pass(stack);
        });
	}
}
  1. Run the mod on fabric.
  2. Use the blaze rod to set the attachment.
  3. Recreate the player by relogging, respawning, or changing dimensions.
  4. Use the stick. The log will show
[17:06:29] [Render thread/INFO] (bugdemo) client has attachment
[17:06:29] [Server thread/INFO] (bugdemo) server has attachment
  1. Run the mod on neoforge with connector & ffapi.
  2. Repeat steps 3-5. The log will show
[17:13:56] [Render thread/INFO] [bugdemo/]: client does not have attachment
[17:13:56] [Server thread/INFO] [bugdemo/]: server has attachment
  1. Use the blaze rod to re-set the attachment, then use the stick. The log will show
[17:18:53] [Render thread/INFO] [bugdemo/]: client has attachment
[17:18:53] [Server thread/INFO] [bugdemo/]: server has attachment

The expected behavior is that when the player is recreated, the server and client will both see the attachment.

Logs

No response

Additional context

Possibly related to FFAPI 2.2.0 using neoforge api for attachment sync.

Linguagem predominante
Java
Estrelas
181
Forks
41
Merge médio
19d 17h
PRs com merge (30d)
1

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de Sinytra/ForgifiedFabricAPI

Todas as issues de Sinytra/ForgifiedFabricAPI

Issues semelhantes

Mais issues de Java

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.