Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

@shopify/shopify_function@2.0.1 pulls vulnerable lodash chain via @graphql-codegen/cli@5.0.6 (Dependabot PR #87 already exists)

Aberta
#98 1 comentário 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
1/5
Tempo estimado
Menos de uma hora
Facilidade para iniciantes
25/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Estagnada
Stack de tecnologia
node.js, typescript
Domínio
security, tooling

Direção de pesquisa

Start by reviewing Dependabot PR #87, which bumps @graphql-codegen/cli from 5.0.6 to 6.1.1, and compare it with the package dependency declaration. Run npm install and npm audit against the affected package; done means the lodash dependency chain and its reported advisories are cleared after the update is merged.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Summary

@shopify/shopify_function@2.0.1 exact-pins @graphql-codegen/cli@5.0.6, which transitively pulls @graphql-codegen/plugin-helpers@5.1.1, which depends on lodash@~4.17.0. Newer versions of plugin-helpers (6.2.1+, released 2026-04-04) drop the lodash dependency entirely. Bumping @graphql-codegen/cli to a current 6.x or 7.x release transitively resolves all 13 lodash-chain advisories that consuming projects see in npm audit.

PR #87 (Bump @graphql-codegen/cli from 5.0.6 to 6.1.1) has been open since 2026-01-12 and would fix this. It just needs review and merge.

Reproduction

In any project that depends on @shopify/shopify_function@2.0.1 (e.g. a Shopify Function extension generated via shopify app generate extension):

npm install
npm audit

Output (captured 2026-05-08):

13 high severity vulnerabilities

npm ls lodash confirms the chain:

└─┬ @shopify/shopify_function@2.0.1
  └─┬ @graphql-codegen/cli@5.0.6
    ├─┬ @graphql-codegen/plugin-helpers@5.1.1
    │ └── lodash@4.17.23
    ├─┬ @graphql-tools/prisma-loader@8.0.17
    │ └── lodash@4.17.23 deduped
    └─┬ inquirer@8.2.7
      └── lodash@4.17.23 deduped

npm audit flags both GHSA-r5fr-rjxr-66jc (CVSS 8.1, code injection via _.template) and GHSA-f23m-r3pf-42rh (CVSS 6.5, prototype pollution in _.unset / _.omit). All 13 advisories report fixAvailable: false because @shopify/shopify_function@2.0.1 is the latest published version and exact-pins the codegen versions, so consuming npm install cannot bump the chain on its own.

Why this is awkward to work around downstream

Consumers can apply an npm overrides block to force lodash: "^4.18.1", which we did in our project. But every consuming Shopify Function project has to repeat the workaround. And each Dependabot scan still re-flags the chain because the override is invisible to the advisory database walker.

Proposed fix

Merge PR #87 (Bump @graphql-codegen/cli from 5.0.6 to 6.1.1), or open a fresh PR bumping @graphql-codegen/cli to ^7.0.0.

Why this works:

  • @graphql-codegen/cli@6.1.1 declares @graphql-codegen/plugin-helpers: "^6.1.0". Caret resolution floats to the latest 6.x, currently 6.3.0, which dropped the lodash dependency.
  • @graphql-codegen/cli@7.0.0 declares @graphql-codegen/plugin-helpers: "^7.0.0", also lodash-free.

Either path fully clears the 13 lodash-chain advisories without further dependency edits.

Severity (honest)

The deployed Wasm function does not include lodash or any @graphql-codegen/* package, so this is not a runtime exploit. The risk is dev-time only: developer machines and CI runners load the vulnerable lodash code when running npx graphql-codegen or shopify app function typegen. The actual exploit primitives in both advisories (_.template injection, _.unset / _.omit prototype pollution) are not reached by plugin-helpers@5.1.1, which calls lodash/merge.js only. So the realistic risk is "noise in npm audit output and Dependabot triage burden across every consuming project," not "active CVE in production."

Filing this anyway because:

  1. The fix is one Dependabot PR merge. Mechanical, low risk.
  2. A 4-month-old open Dependabot PR (#87) shouldn't be the bottleneck.
  3. Every consuming extension currently has to apply the same overrides workaround.

Versions

  • @shopify/shopify_function@2.0.1 (latest, published 2026-01-30)
  • npm 10.x
  • Reproduced on macOS 14.x, Node.js 22.x

Related

  • Issue #23 (closed 2025-01-31): same package, different transitive vuln (ws chain). Maintainer fixed it in 1.0.4 within 2 days. Citing here to confirm the issue template / response loop works.
  • Open PRs already addressing this: #87 (cli), #86 (typescript), #85 (typescript-operations).
Linguagem predominante
TypeScript
Estrelas
35
Forks
9
Métricas de merge de PRs
Nenhum PR com merge em 30d

Guia de contribuição

Abrir o guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de Shopify/shopify-function-javascript

Todas as issues de Shopify/shopify-function-javascript

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.