Cursor position needs to be adjusted in some uncommon cases when rendering in screen reader mode
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Facilidade para iniciantes
- 45/100
- Tipo de issue
- Bug
- Clareza
- Razoavelmente clara
- Status de atividade
- Estagnada
- Stack de tecnologia
- csharp
- Domínio
- accessibility, cli
Direção de pesquisa
Start with the screen reader rendering flow described in the issue and review the original discussion in PR #4854. Reproduce the cursor-at-d example by pasting defghi into abcdef, then verify that the terminal displays abcdefghidef rather than abcghidef.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Prerequisites
- Write a descriptive title.
- Make sure you are able to repro it on the latest released version
- Search the existing issues, especially the pinned issues.
Exception report
N/A
Screenshot
N/A
Environment data
PS Version: 7.5.2
PS HostName: ConsoleHost (Windows Terminal)
PSReadLine Version: 2.4.3-beta3
PSReadLine EditMode: Windows
OS: 10.0.26100.1 (WinBuild.160101.0800)
BufferWidth: 150
BufferHeight: 40
Steps to reproduce
In Screen Reader mode, the way rendering works is to first calculate the common prefix between the last rendered string and the current string, and then move cursor (as needed) to the position of commonPrefixLength to erase the rest of the previous rendering and write the diff part from the current string.
There could be a problem when user moves the cursor and then inserts (or select-then-delete) a sequence of characters.
One example:
- Previous line is
abcdef, cursor is at the letterd - Press
ctrl+vto pastedefghi
In this case, the new buffer is abcdefghidef, and commonPrefixLength == previousBuffer.Length, but the cursor is still at the first letter d when code flow reaches here. Then writting out the new diff ghidef will result in abcghidef displayed in terminal.
When execution reaches the screen reader rendering, _current is already changed -- it no longer reflects where the cursor is at. This uncommon scenario is tricky, and it potentially could affect the commonPrefixLength != previousBuffer.Length case.
The original discussion is at https://github.com/PowerShell/PSReadLine/pull/4854#discussion_r2286301586
Expected behavior
Cursor position needs to be adjusted in those cases. For the specific example described above, the result text on terminal should be abcdefghidef.
Actual behavior
For the example described above, the result text on terminal should be abcghidef.
- Linguagem predominante
- C#
- Estrelas
- 4.4k
- Forks
- 341
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de PowerShell/PSReadLine
-
Needs-Triage :mag:
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
PowerShell/PSReadLine#5205 ·
-
Needs-Triage :mag:
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
PowerShell/PSReadLine#5195 ·
-
Needs-Triage :mag:
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
PowerShell/PSReadLine#5121 ·
-
Needs-Triage :mag:
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 64/100
PowerShell/PSReadLine#5045 ·
-
Area-CommandHelp Issue-Enhancement
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 68/100
PowerShell/PSReadLine#3470 · 3 reações ·
Todas as issues de PowerShell/PSReadLine
Issues semelhantes
-
bug frontend good first issue
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
-
NavigationViewItemAutomationPeer implements IInvokeProvider but never advertises the Invoke pattern Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
unoplatform/uno#24629 ·
-
agentic-workflows Needs: Triage :mag: State: In-PR
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
-
CS0162 "Unreachable code detected" warning from a MSBuildTemp .tmp file in every game project Abertabug
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 90/100
-
Type: enhancement
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
apache/arrow-adbc#4809 ·