Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

[BUG]: cleanup-pr-previews never removes previews of deleted PRs

Aberta Para iniciantes
  • Algo errado?
#2,952 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
84/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
github, github-actions, shell
Domínio
ci-cd, devops

Direção de pesquisa

Comece com ci/cleanup-pr-previews por volta das linhas 137-139 e execute o comando dry-run documentado a partir da raiz do repositório. Reproduza o comportamento 404 do PR #2308 e, em seguida, verifique se o tratamento de status distingue um PR excluído de outras falhas da API e remove apenas a pasta de preview apropriada.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

triage
Is this a duplicate?
Type of Bug

Silent Failure

Component

Infrastructure

Describe the bug

ci/cleanup-pr-previews is supposed to remove preview folders for closed, merged, and deleted PRs. The deleted-PR case never matches.

For a PR that no longer exists, gh api ... --jq '.state' exits non-zero but still prints the 404 JSON body to stdout. The || echo "not_found" fallback is then appended to that output instead of replacing it:

https://github.com/NVIDIA/cuda-python/blob/f9ed2bdaede7b66e6323dc7772a93953af39dfc7/ci/cleanup-pr-previews#L137-L139

PR_STATUS becomes {"message":"Not Found",...}not_found. That falls through to the *) branch, which logs UNKNOWN and keeps the folder.

This is happening now with docs/pr-preview/pr-2308 on gh-pages. #2308 no longer exists (both the pulls and issues endpoints return 404), and its preview has been there since 2026-07-07. The last scheduled run logged:

[UNKNOWN] PR #2308 has unexpected status: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"404"}not_found
...
Folders to remove: 0

https://github.com/NVIDIA/cuda-python/actions/runs/36217108226

How to Reproduce

Run the script in dry-run mode from the repo root (read-only; it needs GH_TOKEN):

GH_TOKEN="$(gh auth token)" ci/cleanup-pr-previews --dry-run

Relevant output on current main:

[CHECK] Checking PR #2308...
[UNKNOWN] PR #2308 has unexpected status: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"404"}not_found
...
Total PR preview folders: 25
Open PRs: 24
Folders to remove: 0

One of the 25 folders belongs to a PR that no longer exists, but nothing is marked for removal.

The failing call on its own:

PR_STATUS=$(gh api repos/NVIDIA/cuda-python/pulls/2308 \
    --header "Accept: application/vnd.github+json" \
    --jq '.state' 2>/dev/null || echo "not_found")
printf '[%s]\n' "$PR_STATUS"

With gh 2.97.0 this prints:

[{"message":"Not Found","documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"404"}not_found]
Expected behavior

A 404 from the pulls endpoint is classified as not_found, and the folder is removed. A fix should keep other failures (network errors, 5xx) out of the removal path, so a transient API error can't delete an open PR's preview.

#2914 also edits this script, though not these lines. I can send a small fix for the status check, before or after #2914 lands, whichever is easier to review.

Linguagem predominante
Cython
Estrelas
3.4k
Forks
329
Merge médio
1d 15h
PRs com merge (30d)
112

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de NVIDIA/cuda-python

Todas as issues de NVIDIA/cuda-python

Issues semelhantes

Mais issues de DevOps

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.