wallet: Make and record an init-messenger pattern decision

Aberta
#8,790 0 comentários 0 reações 1 responsável Ver no GitHub

Mantenedores costumam responder em até 1 dia

@grypez já está trabalhando nisso.

Desde 26/5/2026.

Avaliação

Esta issue ainda não foi avaliada.

Descrição

team-ocap-kernel
Problem

The extension and mobile clients both create two restricted messengers per controller: a controller messenger (runtime, narrow privileges) and an init messenger (boot-only, broader privileges for one-shot setup steps). The wallet currently uses a single messenger per controller. Whether to adopt the two-messenger pattern is unresolved and undocumented. Without a written decision, every new controller wired into the wallet inherits this ambiguity silently.

Proposed direction

Evaluate the trade-offs and write a short decision document (init-messenger-decision.md) in the wallet package recording the chosen approach and the concrete conditions under which it should be revisited. Link from the package README.

To inform the decision, gather empirical data on which messenger actions are invoked during init() vs. at runtime across the controllers already wired (see sub-issue for tooling). If the init-time and runtime allowlists are effectively the same, the two-messenger pattern adds boilerplate without narrowing any privileges — which favors deferring adoption.

Acceptance
  • A decision is made and written down in packages/wallet/init-messenger-decision.md.
  • The document covers: which pattern is chosen, why, and what conditions would trigger revisiting.
  • packages/wallet/README.md links to the decision document.
Context
  • Extension reference: app/scripts/messenger-client-init/ — getInitMessenger / getMessenger factory pattern.
  • Mobile reference: app/core/Engine/messengers/ — same dual-factory convention.
Subissues
  • #8791
Linguagem predominante
TypeScript
Estrelas
422
Forks
313
Merge médio
1d 8h
PRs com merge (30d)
414

Preparar o ambiente

  • Sem Dockerfile nem arquivo Docker Compose
  • Tem um modelo de pull request
  • Sem guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de MetaMask/core

Todas as issues de MetaMask/core

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.