Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Adopt the `minimal_config` test factory across the suite and add a CI guard on its adoption rate

Aberta
  • Algo errado?
#910 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
45/100
Tipo de issue
Refatoração
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
github-actions, python
Domínio
ci-cd, testing

Direção de pesquisa

Start by reading minimal_config in tests/_helpers/factories, then grep tests/test_*.py for inline "name_or_path": dicts to see which modules still build configs by hand. The guard script tools/check_test_factory_adoption.py does not exist yet; it needs to fail below 70% adoption and be wired into ci.yml and tests/test_guard_wiring.py. Done means the migrated modules pass, the guard runs in CI, and the CHANGELOG names the deferral ID.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area: dev-tooling severity: low source: roadmap wave: 4

Deferred work · F-PR29-A4-03 · severity Low · cost ~3-4 h · recorded in docs/roadmap/risks-and-decisions.md:81

Summary

tests/_helpers/factories.minimal_config is documented as the single source of a minimal valid ForgeConfig, but only 21 of 128 test modules use it and 21 modules build inline config dicts without it, so a schema change has to be applied by hand to every inline copy. The PR #29 plan was a bulk migration plus tools/check_test_factory_adoption.py failing CI below 70 % adoption; adoption has since fallen from 30 % to about 16 % as the suite grew.

Condition or budget

None recorded (the row still names v0.6.x, long past). Guard threshold: 70 % adoption.

State today (re-checked 2026-10-09)

21 of 128 tests/test_*.py modules use the factory; 36 modules hold 116 inline "name_or_path": config dicts; tools/check_test_factory_adoption.py does not exist.

Acceptance criteria

  • Inline ForgeConfig dicts in tests use minimal_config(...) (or document why they cannot).
  • tools/check_test_factory_adoption.py fails below the agreed rate and is wired into ci.yml, the CLAUDE.md / AGENTS.md / CONTRIBUTING.md gauntlet and tests/test_guard_wiring.py.
  • The row is removed from the deferral table and the CHANGELOG names its ID (the table's removal contract).

Recorded in docs/roadmap/risks-and-decisions.md (read at f94595f) and re-checked against the code on 2026-10-09. The row leaves that table only when the fix is on main, the CHANGELOG names its ID and any promised guard exists.

Linguagem predominante
Python
Estrelas
9
Forks
1
Merge médio
7h 53min
PRs com merge (30d)
58

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de HodeTech/ForgeLM

Todas as issues de HodeTech/ForgeLM

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.