Widget alignment in editor: Use first widget or outline of all widgets?

Aberta
  • Algo errado?
#3,801 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
30/100
Tipo de issue
Funcionalidade
Clareza
Precisa de esclarecimento
Status de atividade
Pouca atividade
Stack de tecnologia
java
Domínio
desktop

Direção de pesquisa

Start by comparing the behavior described in PR #509 with its imported version, PR #579, then locate the display editor’s alignment actions. The issue presents several competing options but does not choose one, so agree on the intended behavior before implementation; done means the chosen alignment behavior is clear and matches the rectangle-and-label example.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

discussion

The display editor alignment options were initially relative to the first selected widget.
Select a widget, add other widgets to the selection, and when you then align left/right/center, all widgets would be aligned to the left/right/center of the first selected widget.

In https://github.com/kasemir/org.csstudio.display.builder/pull/509 (later imported to phoebus as https://github.com/ControlSystemStudio/phoebus/pull/579), that behavior was changed.
Now left/right/center aligns all selected widget to the left/right/center of the combined widget outline.

The original behavior is more straight forward for precision alignment.
Select a widget that's already in the desired location, then select others and align them to the left/right/center of the first one.

Example:
Create a rectangle, place it as desired.
Create a Label, set text.
Select rectangle, then label, "Align center" and the text will be in the center of the rectangle.

Downside of the original behavior: Nobody knows how to select one widget, then add others to the selection. Need to hold control, command, alt or shift? Much easier to rubber band around all the widgets of interest and align to the outline. But now it's harder to truly align things.

Example:
Create a rectangle, place it as desired.
Create a Label, set text.
Rubberband-select rectangle and label
"Align center" and BOTH widgets will move to the center of their combined outline, so rectangle is no longer where you wanted it.

Options:

Keep as is. Alignment is slightly useless, but I never use it anyway?

Restore original alignment relative to first selected widget, and nobody will remember how to use that?

Remove alignment options to simplify user interface?

Linguagem predominante
Java
Estrelas
130
Forks
132
Merge médio
2d 7h
PRs com merge (30d)
26

Preparar o ambiente

  • Sem Dockerfile nem arquivo Docker Compose
  • Tem um modelo de pull request
  • Sem guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de ControlSystemStudio/phoebus

Todas as issues de ControlSystemStudio/phoebus

Issues semelhantes

Mais issues de Java

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.