[2.8] Refuse unsigned identity overwrites for known signers

Open
  • Is something wrong?
#447 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
backend, security

Research direction

The identity overwrite happens in packets/services/node_info.py, lines 21-29, where any NodeInfo updates the stored identity. Read the parent issue pskillen/meshflow-api#437 and the dependency #446 (SG-2) first, since this change relies on knowing which nodes are known signers. Done means unsigned NodeInfo is ignored for known signers, signed updates still apply, and tests cover both cases.

Written by the indexing model from the issue text.

Description

enhancement meshtastic-2.8

Part of pskillen/meshflow-api#437 (Meshtastic 2.8.x support). Code: SG-3 · Priority: Nice · Size: S

Summary

packets/services/node_info.py:21-29 overwrites identity from any NodeInfo. For a node known to sign, ignore unsigned NodeInfo identity changes (mirrors the firmware's Balanced policy).

Acceptance criteria

  • Tests

Depends on: pskillen/meshflow-api#446 (SG-2)

Dominant language
Python
Stars
1
Forks
0
Avg merge
1d 20h
Merged PRs (30d)
5

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pskillen/meshflow-api

All issues in pskillen/meshflow-api

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.