Block parameter size?

Open
#35 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Domain
tooling

Research direction

Start by reviewing the block parameter and block data definitions in the specification. Compare the two proposed ways to encode parameter size, and document whether block size includes the checksum; done means the format unambiguously lets generic readers skip current and future block types.

Written by the indexing model from the issue text.

Description

According to the spec, the size of the block parameters is variable, but not defined anywhere in the block.

This is not a good idea, since a generic reader will not know how to skip past block types that may be defined in the future.

Two possible solutions are suggested:

  • Include a field with the block parameter size, or
  • Let the block data size include the size of the block parameters as well

You should also be explicit about whether the block size includes or does not include the size of the checksum.

Dominant language
G-code
Stars
73
Forks
24
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from prusa3d/libbgcode

All issues in prusa3d/libbgcode

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.