Should `goog.DEBUG` be false for builds distributed via npm?

Open
#9 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
build-system

Research direction

Read closure/goog/base.js at lines 224-230 and inspect the gulpfile's Closure Compiler invocation. Compare the generated google-protobuf.js runtime in the npm package with the intended production behavior, then determine whether the build should change, expose configuration, or distribute multiple builds.

Written by the indexing model from the issue text.

Description

help wanted packaging & distribution triaged

goog.DEBUG is true in the google-protobuf.js runtime distributed in the npm package. This setting gates the various assertion code in the runtime (goog.asserts.ENABLE_ASSERTS = goog.DEBUG;).

  1. Is this expected?
  2. If so, should DEBUG be set to false for production builds? And should two builds be distributed, or a means be exposed to configure this?
  3. If not, should the gulpfile that generates the runtime supply --define goog.DEBUG=false to the closure compiler invocation?
Dominant language
JavaScript
Stars
471
Forks
92
PR merge metrics
No merged PRs in 30d

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from protocolbuffers/protobuf-javascript

All issues in protocolbuffers/protobuf-javascript

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.