Generated output is incompatible with Jest (again)

Open
#149 4 comments 1 reaction 1 assignee View on GitHub

@dibenede is already working on this.

Since Nov 2, 2022.

Assessment

This issue has not been assessed yet.

Description

bug triaged

This is the same issue as https://github.com/protocolbuffers/protobuf/issues/9152, which was notionally fixed in https://github.com/protocolbuffers/protobuf/pull/9156. However, it seems that as of 3.20.3 the output is (still? again?) the Jest-incompatible

var global = (function() { return this || window || global || self || Function('return this')(); }).call(null);

For now I've rolled back to 3.11.2 which emits the compatible

var global = Function('return this')();

but this isn't a great long-term solution.

Dominant language
JavaScript
Stars
471
Forks
92
PR merge metrics
No merged PRs in 30d

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from protocolbuffers/protobuf-javascript

All issues in protocolbuffers/protobuf-javascript

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.