Import `project_doc_fallback_filenames` from the reviewed checkout
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions, typescript
- Domain
- ci-cd
Research direction
Start with the setup step that handles $GITHUB_WORKSPACE/.codex/config.toml and $CODEX_HOME/config.toml, and see how codex-config is currently merged. Add a narrow import that copies only project_doc_fallback_filenames, validated as an array of filenames, and skips it when the key is already defined, including an explicit []. Done means fresh, resumed, and forked sessions read the fallback, and a checkout that defines mcp_servers still starts none of its servers. This touches the trust boundary, so get maintainer review before merging.
Written by the indexing model from the issue text.
Description
Codex 0.169.0 treats the reviewed checkout as untrusted, so it skips the checkout's .codex/config.toml. That is the right default for mcp_servers, hooks, and other executable settings, but it also drops project_doc_fallback_filenames, which is just data. A repository that keeps its instructions in CLAUDE.md and selects it through that fallback now gets no project docs during review.
Reproduced on 0.169.0 in an untrusted directory whose .codex/config.toml sets project_doc_fallback_filenames = ["CLAUDE.md"]:
codex exec --dangerously-bypass-approvals-and-sandbox ...printswarning: Untrusted project-local configuration is disabledand does not read the fallback.codex exec -c 'project_doc_fallback_filenames=["CLAUDE.md"]' ...does read it, while the checkout's MCP command and Stop hook stay disabled.
Proposed fix: during setup, parse $GITHUB_WORKSPACE/.codex/config.toml, accept only an array of valid filenames, and prepend that key to $CODEX_HOME/config.toml when codex-config does not already define it (an explicit [] counts as defined). Import only this key. Keep mcp_servers, hooks, model settings, and every other executable setting disabled.
Acceptance: fresh, resumed, and forked sessions all see the fallback; a checkout that defines an MCP server still does not start it.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 1h 39m
- Merged PRs (30d)
- 84
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from promplate/code-review
-
Stop retrying permanent GitHub API failures in retry.shPossibly taken @muspi-merol-review claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
promplate/code-review#113 · 1 comment ·
Maintainers usually reply within 1 day
-
Configure a git identity before the review agent runsPossibly taken @muspi-merol-review claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 1/100
promplate/code-review#112 · 1 comment ·
Maintainers usually reply within 1 day
-
Put the installed codex binary on PATH for review agentsPossibly taken @muspi-merol-review claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 35/100
promplate/code-review#111 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Document Issues write as required for reactions, not just issuesPossibly taken @muspi-merol-review claimed this today. Opendocumentation
Difficulty 1/5 Under an hour Newbie friendliness 25/100
promplate/code-review#100 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
wait-ci.sh never receives the token it excludes sibling runs withPossibly taken @muspi-merol-review claimed this today. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
promplate/code-review#98 · 1 comment ·
Maintainers usually reply within 1 day
All issues in promplate/code-review
Similar issues
-
triage
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
サムネイルの Storage のバケット(`thumbnails`)に、大きさの上限(1 MiB)と許可する種類(JPEG、PNG、WebP)を設定するPossibly taken @ykzts claimed this today. Opentech: supabase
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
inabagumi/shinju-date#7147 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
elecnix/your-attention#129 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
umami-software/umami#4780 ·
Maintainers usually reply within 3 days
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
celo-org/social-connect#487 ·
Maintainers usually reply within 1 day