NULL character on k8s zone labels

Open
#521 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
observability

Research direction

Review prometheus/common/model/metric.go around line 62, where the label value is printed with %q, and compare the behavior with the linked Kubernetes issue. Confirm whether NULL characters should be removed from label values; done means the reported character no longer appears in the resulting label output.

Written by the indexing model from the issue text.

Description

A related issue was opened some time ago https://github.com/kubernetes/kubernetes/issues/73867

This https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-helpers/node/topology/helpers.go#L57 adds the NULL character and then because in prometheus %q is used to print the value https://github.com/prometheus/common/blob/main/model/metric.go#L62 the character is printed.

If it makes sense to you I can open a PR to strip these characters from the label values.

Dominant language
Go
Stars
297
Forks
380
Avg merge
3d 18h
Merged PRs (30d)
12

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from prometheus/common

All issues in prometheus/common

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.