Add a pdb to the helm chart
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 62/100
Research direction
Start with the Helm chart: find where replicaCount is set in the values file and where the controller and Capsule Proxy Deployment templates read it. Add a PodDisruptionBudget template for each component that renders only when replicaCount is greater than 1. Done means that helm template with replicaCount above 1 produces a PDB for both components, and with replicaCount at 1 it produces none.
Written by the indexing model from the issue text.
Description
Describe the feature
Currently there is no PDB option in the chart. This would be nice, because currently there could be a potential issue that all replica's are down if there is a issue with for example node upgrades.
Same for Capsule Proxy.
What would the new user story look like?
Add a default PDB option to the chart.
Potential: automatically enable it when the replicaCount is higher then 1.
Expected behavior
The Capsule pod can't be terminated when the new one is not healthy yet. This PDB should only be there when the replicaCount is higher then 1.
- Dominant language
- Go
- Stars
- 2.2k
- Forks
- 225
- Avg merge
- 1d 59m
- Merged PRs (30d)
- 58
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from projectcapsule/capsule
-
blocked-needs-validation bug
Difficulty 1/5 Under an hour Newbie friendliness 78/100
projectcapsule/capsule#2280 ·
Maintainers usually reply within 1 day
-
Tenant reconcile fails and requeues when a ResourceQuota vanishes during the sync (namespace deleted mid-reconcile)Possibly taken @antoinemichea claimed this 49 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
projectcapsule/capsule#2158 ·
Maintainers usually reply within 1 day
-
Admission webhooks read Namespace, Tenant and RuleStatus from the API server on every requestPossibly taken @antoinemichea claimed this 12 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 44/100
projectcapsule/capsule#2260 ·
Maintainers usually reply within 1 day
-
Admission controller fights AKS Admissions Enforcer over webhook namespaceSelector (0.14.6)Possibly taken @dennispidun claimed this 20 days ago. Openblocked-needs-validation bug
Difficulty 4/5 3-5 days Newbie friendliness 28/100
projectcapsule/capsule#2233 ·
Maintainers usually reply within 1 day
-
feat: volume attribute class on rules apiPossibly taken @Kitio-Tek claimed this 4 days ago. Opendocumentation enhancement
projectcapsule/capsule#2198 · 2 comments · 2 assignees ·
Maintainers usually reply within 1 day
All issues in projectcapsule/capsule
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
router-for-me/CLIProxyAPI#7330 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug os:ios
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
hajimehoshi/ebiten#4039 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 9 days