Incorrect description of git pull behavior in Chapter 3.5 of Pro Git book V2

Open
#1,962 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
58/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
git
Domain
documentation

Research direction

Locate the Pro Git v2 source for Chapter 3.5, “Git Branching - Remote Branches,” and find the “Pulling” section. Update the statement so it clearly says that git pull merges the fetched remote branch into the current local branch, then verify the wording in the generated book output.

Written by the indexing model from the issue text.

Description

bug
There's no existing/similar bug report.
  • I have searched the existing issues
This report is about a single actionable bug.
  • I'm reporting a single actionable bug
This report is about the ProGit book, version 2, English language.
  • This bug is not about a translation or old version
Bug covers book website/pdf
  • I confirm the bug is about the book as found on the website/pdf
Problem is present in the Pro Git book on the website?
  • This bug also affects the Pro Git book as published on the website.
Which version of the book is affected?

Source files

Describe the bug:

The Pro Git v2 book contains a misleading statement about the behavior of git pull in Chapter 3.5
link: https://git-scm.com/book/en/v2/Git-Branching-Remote-Branches

The current statement is:

"git pull will look up what server and branch your current branch is tracking, fetch from that server and then try to merge in that remote branch."

This implies that the merge happens in the remote branch, which is incorrect. The correct behavior is that the merge happens in the local branch.

Steps to reproduce:
  1. Go to https://git-scm.com/book/en/v2/Git-Branching-Remote-Branches
  2. Scroll down to "Pulling" section
  3. See error
Expected behavior:

Current Statement:
"git pull will look up what server and branch your current branch is tracking, fetch from that server and then try to merge in that remote branch."

Corrected Statement:
"git pull will look up which server and branch your current branch is tracking, fetch from that server, and then try to merge that remote branch into your current local branch."

Screenshots:
Screenshot 2024-06-23 at 13 24 02
Additional context:

Location:
Chapter 3.5, Section Pulling
Link: https://git-scm.com/book/en/v2/Git-Branching-Remote-Branches

Device

desktop

Operating system

macos

Browser/application + version

google chrome

Dominant language
CSS
Stars
6.6k
Forks
2.1k
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from progit/progit2

All issues in progit/progit2

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.