Warning but not quit after URL check

Open
#518 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
ruby
Domain
ci-cd

Research direction

Start by reviewing the linked failed GitHub Actions job and comparing the URL-check invocation with the upstream commit “Fix htmlproofer invocation” in progit/progit2. Confirm how the check handles the eight reported failures and whether the desired result is for the action to complete without failing on them.

Written by the indexing model from the issue text.

Description

Our action build failed after url check
遵循原文 修改ruby脚本过时的代码 · progit/progit2-zh@55231ea

But english repo has no problem
Merge pull request #1970 from z-hed/notepad++ · progit/progit2@b3af68c

It seems that url check only output warnings, but not quit

HTML-Proofer found 8 failures!
Command failed with status (1): [htmlproofer progit.html]
Error when checking books (ignored)

Could you help us to just ignore this check? @jnavila
Maybe it could be like this:
Fix htmlproofer invocation · progit/progit2@8de1de7

Dominant language
CSS
Stars
1.6k
Forks
360
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from progit/progit2-zh

All issues in progit/progit2-zh

Similar issues

More DevOps issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.