Переписать реализацию ручки GET lecturer
Nobody has claimed this yet.
- #53 by @Spangi2000 — closed without merging
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start at the GET lecturer handler and inspect how it currently processes comments across its multiple loops. Trace the validation and filtering conditions, then consolidate them into one pass that appends validated models to the result. Confirm that the endpoint still returns the expected lecturer data using the repository's existing checks.
Written by the indexing model from the issue text.
Description
Сейчас не очень хорошая реализация, так как много циклов for по всевозможным комментариям.
Надо переписать реализацию, оставив только один цикл по всем комментариям, а все проверки делать на каждой итерации, затем добавлять свалидированную модельку в result
- Dominant language
- Python
- Stars
- 8
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from profcomff/rating-api
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
profcomff/rating-api#175 ·
-
Написать тесты для проверки ограничений комментариевMay be free again @businkv claimed this 62 days ago, and no pull request is open. Open
profcomff/rating-api#174 · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
profcomff/rating-api#157 ·
-
profcomff/rating-api#112 · 2 comments · 1 assignee ·
-
тесты на запись логов в маркетингMay be free again @parfenovma claimed this 598 days ago, and no pull request is open. Open
profcomff/rating-api#94 · 1 assignee ·
All issues in profcomff/rating-api
Similar issues
-
feature:LinkChecker
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
digitalfabrik/integreat-cms#4594 ·
Maintainers usually reply within 5 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
EleutherAI/lm-evaluation-harness#4319 ·
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
json_params_matcher fails on falsy top-level JSON primitives (0, False, "")Possibly taken @mayureshsonawane17 claimed this today. OpenWaiting for: Product Owner
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 5 days