The "X-Forwarded-Host" header may contain multiple values
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- express, javascript
- Domain
- backend
Research direction
Start by locating the Express middleware code that reads the X-Forwarded-Host header. Reproduce the case with a comma-separated header containing multiple values, then verify that the resulting behavior uses the first value as requested. No test file or implementation path is named in the issue.
Written by the indexing model from the issue text.
Description
The current implementation doesn't take into account the X-Forwarded-Host header may contain multiple values.
From the Apache mod_proxy docs:
Be careful when using these headers on the origin server, since they will contain more than one (comma-separated) value if the original request already contained one of these headers.
Probably in such case you should take the first value from the list.
- Dominant language
- JavaScript
- Stars
- 921
- Forks
- 185
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from prerender/prerender-node
-
Release new version? Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
prerender/prerender-node#274 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
prerender/prerender-node#272 ·
-
Fastify support? Open
Difficulty 5/5 Over a week Newbie friendliness 15/100
prerender/prerender-node#224 · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
prerender/prerender-node#223 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
prerender/prerender-node#220 · 2 comments · 2 reactions ·
All issues in prerender/prerender-node
Similar issues
-
ai-observability bug team/ai-observability
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
AllTheMods/ATM-10-L#19 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
SignalK/n2k-signalk#345 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
JuliaPluto/PlutoPlotly.jl#72 ·