`req.connection.encrypted` is `undefined` in node:14
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- javascript, node.js
- Domain
- backend
Research direction
Start at index.js around line 251 and inspect how the middleware determines the request protocol under Node 14. Replace the unsupported connection property with the protocol-based approach described in the issue, then verify that HTTP and HTTPS requests still produce the expected protocol value.
Written by the indexing model from the issue text.
Description
Need to replace with req.encrypted ? "https" : "http" or more succinctly req.protocol
tried to push my branch to make a PR but I got access denied, can an existing contributor pr this?
- Dominant language
- JavaScript
- Stars
- 921
- Forks
- 185
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from prerender/prerender-node
-
Release new version? Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
prerender/prerender-node#274 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
prerender/prerender-node#272 ·
-
Fastify support? Open
Difficulty 5/5 Over a week Newbie friendliness 15/100
prerender/prerender-node#224 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
prerender/prerender-node#220 · 2 comments · 2 reactions ·
-
enhancement
prerender/prerender-node#214 · 7 comments · 1 assignee ·
All issues in prerender/prerender-node
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
palladius/rails8-app-on-gcp#145 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
dotenvx/dotenv-vscode#139 ·
-
test-change-proposal
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
web-platform-tests/interop#1455 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
corsairdev/corsair#1764 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100