Location header

Open
#171 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
backend

Research direction

Start by tracing the beforeRender callback and how cached responses handle status and headers. Verify where the requested location value is read and propagated; done means a cached 301 response includes its Location header. No file or test path is named in the issue.

Written by the indexing model from the issue text.

Description

There is currently no way to pass in a Location: header in the beforeRender. This therefore breaks a cached 301 response, as the status is set to 301, but the Location isn't set.

Need to be able to:

done(err, {body: fields[0], status: fields[1], location: fields[2]});

Dominant language
JavaScript
Stars
921
Forks
185
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from prerender/prerender-node

All issues in prerender/prerender-node

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.