Absorb ImageVersionOS into ImageVersion
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
Research direction
Start with config/image/version_os.py and config/image/version.py to compare the fields, methods, and validator that must move. Read config/image/build_os.py to keep BuildOS lookup separate. Done means ImageVersion owns the absorbed behavior, version_os.py is deleted, and image version resolution no longer depends on the wrapper.
Written by the indexing model from the issue text.
Description
`ImageVersionOS` (`version_os.py`, 133 LOC) is a shallow wrapper: 8 fields, 4 methods, 1 validator. It handles `BuildOS` lookup and adds `primary`, `extension`, and `tagDisplayName` fields. The indirection adds a parent-pointer contract without hiding meaningful complexity.
Absorb the fields and methods directly into `ImageVersion`. `BuildOS` lookup logic stays separate. Delete `version_os.py`. Reduces the number of files needed to trace image version resolution from ~11 to ~9.
Files: `config/image/version_os.py`, `config/image/version.py`, `config/image/build_os.py`
- Dominant language
- Python
- Stars
- 2
- Forks
- 0
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 20
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from posit-dev/images-shared
-
cvp:0 docker tdp:1
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
posit-dev/images-shared#757 · 2 comments ·
Maintainers usually reply within 1 day
-
bug cvp:0 docker priority/medium python tdp:1
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
posit-dev/images-shared#685 ·
Maintainers usually reply within 1 day
-
slack-build-notify: no persisted alert state — causes suppressed repeat-failure and recovery alertsOpenbug cicd cvp:0 docker needs discussion observability tdp:2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
posit-dev/images-shared#677 ·
Maintainers usually reply within 1 day
-
cvp:0 docker tdp:2 tech debt
Difficulty 4/5 3-5 days Newbie friendliness 48/100
posit-dev/images-shared#795 ·
Maintainers usually reply within 1 day
-
cicd cvp:0 docker enhancement tdp:2
Difficulty 5/5 Over a week Newbie friendliness 35/100
posit-dev/images-shared#773 ·
Maintainers usually reply within 1 day
All issues in posit-dev/images-shared
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
qgis/QGIS-Plugins-Website#459 ·
-
bug severity:medium
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
bot-found bug priority: P3
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
madenvel/KalinkaPlayer#179 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ls1intum/edutelligence#1098 ·
Maintainers usually reply within 1 day