refactor: remove __ping__ request
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
Research direction
Start in R/utils.R at check_connect_license() and in R/connect.R at Connect$raise_error() to trace the current 402 handling. Remove the ping request, centralize its special messaging in raise_error(), and delete the various ping.json test mock files. Done means invalid-license errors retain the special message without an extra request and the affected tests pass.
Written by the indexing model from the issue text.
Description
check_connect_license() calls the __ping__ endpoint and looks for 402 response to indicate that the license is not valid. But we don't need to do that because any request will error that way if the license is invalid. So just move the special messaging for 402 errors into Connect$raise_error() and delete this unnecessary server request.
Also delete the various __ping__.json test mock files, as they are no longer needed.
- Dominant language
- R
- Stars
- 54
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from posit-dev/connectapi
-
Difficulty 1/5 Under an hour Newbie friendliness 62/100
posit-dev/connectapi#249 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
posit-dev/connectapi#527 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
posit-dev/connectapi#526 · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
posit-dev/connectapi#506 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
posit-dev/connectapi#486 ·
All issues in posit-dev/connectapi
Similar issues
-
bug priority: should
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
The-Strategy-Unit/nhp_outputs#477 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Open-Systems-Pharmacology/OSPSuite.ReportingEngine#1380 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Open-Systems-Pharmacology/OSPSuite.ParameterIdentification#335 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100