Two public SystemHost types: the core one is always UTC, the host crate's uses the system time zone
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 52/100
Research direction
Start by reading core/src/host.rs around SystemHost and adapters/native/src/system.rs to compare the two public types, then check how Runtime::new() and Runtime::new_with_host_services expose them. The issue suggests renaming the core type while keeping the host crate's SystemHost; trace the public exports and update affected references. Done means the types are unambiguous and the documented host behavior remains accurate.
Written by the indexing model from the issue text.
Description
Two public types are named SystemHost and behave differently:
| Path | Clock | Time zone |
|---|---|---|
quickjs_oxide::engine::api::core::SystemHost (re-export of oxide_core::host::SystemHost, core/src/host.rs:84) |
system | always UTC |
quickjs_oxide_host::SystemHost (adapters/native/src/system.rs:19) |
system | TZ / /etc/localtime via tz-rs |
Runtime::new() uses the first; the README and the docs use the second with Runtime::new_with_host_services. A use quickjs_oxide::engine::api::core::*; plus use quickjs_oxide_host::SystemHost; is a name clash, and importing the wrong one silently gives UTC dates.
Suggestion: rename the core one to what it is (e.g. UtcHost / DefaultHost), keeping SystemHost only in quickjs-oxide-host.
- Dominant language
- Rust
- Stars
- 61
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pocket-stack/quickjs-oxide
-
Difficulty 4/5 3-5 days Newbie friendliness 44/100
pocket-stack/quickjs-oxide#192 · 3 comments ·
-
performance.now() bypasses Host and uses std::time::Instant (unsupported on wasm32-unknown-unknown)Openbug
Difficulty 4/5 3-5 days Newbie friendliness 52/100
pocket-stack/quickjs-oxide#165 · 1 comment ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 56/100
pocket-stack/quickjs-oxide#163 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
pocket-stack/quickjs-oxide#158 · 1 comment ·
-
Execution slow paths: inline-cache misses (Gameboy), typed-array access (zlib), array stores (Sieve)Open
Difficulty 5/5 Over a week Newbie friendliness 35/100
pocket-stack/quickjs-oxide#157 ·
All issues in pocket-stack/quickjs-oxide
Similar issues
-
area:web kind:bug priority:p2 ready
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 84/100
sims1253/r-typeshed#140 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
storytold/craft-libs#2867 ·
Maintainers usually reply within 1 day
-
help wanted needs investigation priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 62/100