microts: compiled-model analysis crashes with "undefined is not an object (evaluating 'ast.statements')" when the model file is not in the TypeScript program

Open
#722 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
66/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
bun, typescript
Domain
compilers

Research direction

Reproduce with the --output (guest) build first, then read microts/compiler/aot-model-view.ts:12 (the realpathSync model lookup) against microts/compiler/aot-solid-frontend.ts:89 (createTypeEnvironment), which builds the program from view files. Add a temporary log of the requested path and env.program.getSourceFile(file) to confirm the two mismatches described (missing from program in A, /tmp vs /private/tmp in B), then fix all three dereference sites: aot-model-frontend.ts:827, :854, :1068. Done looks like both repros compiling, or a located diagnostic instead of the ast.statements TypeError.

Written by the indexing model from the issue text.

Description

bug

Version

PocketJS v0.17.0 (83c6cac9, current main). macOS 27.2 arm64 (APFS, /tmp is a symlink to private/tmp), Bun 1.4.2.

Repro

Two triggers, one crash site.

pocket.host.json, pocket.host.config.ts, main.tsx, app.ts
{
  "format": "pocket-host/2",
  "id": "repro-esp32s3",
  "platform": "esp-idf",
  "form": "takeover",
  "cadences": [30],
  "display": {
    "logicalViewports": [[240, 240]],
    "presentations": ["native"],
    "rasterDensity": 1,
    "animation": "repaint"
  },
  "panel": { "primary": [240, 240] },
  "capabilities": ["input.buttons", "text.glyphs.baked"]
}
// pocket.host.config.ts
import { defineHostConfig } from "@pocketjs/framework/host-config";

export default defineHostConfig({
  host: "./pocket.host.json",
  app: {
    id: "dev.example.repro",
    title: "Repro",
    version: "0.1.0",
    entry: "main.tsx",
    output: "repro",
    framework: "solid",
    viewport: { logical: [240, 240], presentation: "native" },
    features: ["input.buttons", "text.glyphs.baked"],
    aot: true,
    model: "compiled",
  },
});
// main.tsx
import { mount } from "@pocketjs/framework/solid";
import App from "./app.tsx";
mount(() => <App />);
// app.ts
import { createSignal } from "solid-js";
import type { i32 } from "@pocketjs/framework/solid/std";
export const [count, setCount] = createSignal<i32>(0);
A: the root view does not import its model
// app.tsx
import { Text, View } from "@pocketjs/framework/solid/components";

export default function App() {
  return (
    <View class="w-full h-full p-4 bg-slate-100">
      <Text class="text-lg text-slate-900">Hello</Text>
    </View>
  );
}
bun $POCKETJS/tools/pocket.ts compile --config pocket.host.config.ts --aot --out gen
B: the project is reached through a symlink

The same files, with an app.tsx that imports ./app (import { count, setCount } from "./app"; and uses both), in /tmp/repro with node_modules resolvable from there. Run from another directory:

bun $POCKETJS/tools/pocket.ts compile --config /tmp/repro/pocket.host.config.ts --aot --out /tmp/repro/gen

Run from inside the directory with --config pocket.host.config.ts, the same project compiles: process.cwd() is already /private/tmp/repro.

Actual

A and B, in both --aot and guest (--output) builds:

PocketJS: undefined is not an object (evaluating 'ast.statements')

Stack from the guest build:

TypeError: undefined is not an object (evaluating 'ast.statements')
      at analyzeModel (microts/compiler/aot-model-frontend.ts:828:24)
      at analyzeViewModel (microts/compiler/aot-model-view.ts:13:15)
      at analyzeSolidAot (microts/compiler/aot-solid-frontend.ts:91:17)
      at checkSolidAotGraph (microts/compiler/aot-solid-browser.ts:39:137)
      at getSolidAotProgram (microts/compiler/aot-solid-browser.ts:84:20)
      at transformFile (framework/compiler/jsx-plugin.ts:554:69)
      at walk (tools/build.ts:309:21)

Expected

  • A: the model is analyzed (a root model can hold state and tasks the view does not read), or the compiler reports a located diagnostic such as "app.tsx does not import its model app.ts".
  • B: the project compiles as it does from its canonical path.

Cause

The TypeScript program holds the view files and the modules they import (createTypeEnvironment(files, entry), microts/compiler/aot-solid-frontend.ts:89). analyzeViewModel selects the model by file-system lookup and canonicalizes it with realpathSync (microts/compiler/aot-model-view.ts:12). analyzeModel then reads env.program.getSourceFile(file)! (microts/compiler/aot-model-frontend.ts:827) and dereferences it.

  • In A, no view imports app.ts, so it is not in the program.
  • In B, the program holds /tmp/repro/app.ts and the lookup asks for /private/tmp/repro/app.ts.

aot-model-frontend.ts:854 and :1068 read getSourceFile(file)! the same way.

Workaround

  • A: import a value from the model in the view and use it.
  • B: compile from the canonical path (cd "$(pwd -P)", or pass a --config path without symlinks).
Dominant language
TypeScript
Stars
1.6k
Forks
88
PR merge metrics
No merged PRs in 30d

Getting set up

We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pocket-stack/pocketjs

All issues in pocket-stack/pocketjs

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.