Raffia usage suggestion
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start in src/style.rs at the normalization around line 69 and check how the stylesheet parser is built. Read Raffia’s ParserBuilder documentation for try_parsing_value_in_custom_property, then verify that enabling it parses custom property values and allows the normalization function to be removed. Done when the parser handles those values and the redundant normalization is gone.
Written by the indexing model from the issue text.
Description
I noticed that there's a normalization in https://github.com/pnpm/xray/blob/e98dca7395a4e83254315160c94a39b325c5a6c4/src/style.rs#L69 but actually Raffia can parse declaration values for custom properties. To achieve, consider using the ParserBuilder API and enable the try_parsing_value_in_custom_property option. If it works for you, that normalization function can be removed.
- Dominant language
- Rust
- Stars
- 6
- Forks
- 0
- Avg merge
- 23h 26m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pnpm/xray
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mongodb/kingfisher#588 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
bug rust
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
franciscoBSalgueiro/en-croissant#1111 ·
Maintainers usually reply within 2 days
-
[bug] Toolchain versions from `.prototools` are not inherited when moon runs from a subdirectoryOpen
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day