Raffia usage suggestion

Open Beginner friendly
#8 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
backend

Research direction

Start in src/style.rs at the normalization around line 69 and check how the stylesheet parser is built. Read Raffia’s ParserBuilder documentation for try_parsing_value_in_custom_property, then verify that enabling it parses custom property values and allows the normalization function to be removed. Done when the parser handles those values and the redundant normalization is gone.

Written by the indexing model from the issue text.

Description

I noticed that there's a normalization in https://github.com/pnpm/xray/blob/e98dca7395a4e83254315160c94a39b325c5a6c4/src/style.rs#L69 but actually Raffia can parse declaration values for custom properties. To achieve, consider using the ParserBuilder API and enable the try_parsing_value_in_custom_property option. If it works for you, that normalization function can be removed.

Dominant language
Rust
Stars
6
Forks
0
Avg merge
23h 26m
Merged PRs (30d)
1

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pnpm/xray

All issues in pnpm/xray

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.