Unmanaged Devices don't appear in IP report
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
Research direction
Start in inc/addressing.class.php, focusing on the $types handling for Unmanaged Devices and the generated IP report query. Reproduce the report with debug mode enabled and inspect the reported ambiguous ip grouping warning. Done means Unmanaged Devices appear in the IP report without the SQL warning.
Written by the indexing model from the issue text.
Description
GLPI 10.0.10
IP Adressing 3.0.2
Debian bookworm
I would like to make appear in IP reports Unmanaged Devices discovered by GLPI NetDiscovery tasks, to have a complete view of used IPs in a network.
inc/addressing.class.php contains a code section dedicated to Unmanaged Devices, but $types does not contain Unmanaged.
Unmanaged Devices appear properly in report if I add Unmanaged in $types.
But debug mode shows following message.
What is wrong ?
SQL Warnings: 1052: Column 'ip' in group statement is ambiguous in query "SELECT port.id, 'NetworkEquipment' AS itemtype, dev.id AS on_device, dev.name AS dname, '' AS pname, glpi_ipaddresses.name as ip, port.mac, dev.users_id, INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_networkequipments dev ON (port.items_id = dev.id AND port.itemtype = 'NetworkEquipment') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND dev.is_deleted = 0 AND dev.is_template = 0 AND ( dev.entities_id = '3' ) UNION (SELECT port.id, 'Computer' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,dev.users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_computers dev ON (port.items_id = dev.id AND port.itemtype = 'Computer') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'NetworkEquipment' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,dev.users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_networkequipments dev ON (port.items_id = dev.id AND port.itemtype = 'NetworkEquipment') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Peripheral' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,dev.users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_peripherals dev ON (port.items_id = dev.id AND port.itemtype = 'Peripheral') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Phone' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,dev.users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_phones dev ON (port.items_id = dev.id AND port.itemtype = 'Phone') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Printer' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,dev.users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_printers dev ON (port.items_id = dev.id AND port.itemtype = 'Printer') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Enclosure' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,0 AS users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_enclosures dev ON (port.items_id = dev.id AND port.itemtype = 'Enclosure') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'PDU' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,0 AS users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_pdus dev ON (port.items_id = dev.id AND port.itemtype = 'PDU') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Cluster' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,0 AS users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_clusters dev ON (port.items_id = dev.id AND port.itemtype = 'Cluster') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Unmanaged' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,0 AS users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_unmanageds dev ON (port.items_id = dev.id AND port.itemtype = 'Unmanaged') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' GROUP BY ip, port.mac ORDER BY ipnum)"
- Dominant language
- PHP
- Stars
- 43
- Forks
- 23
- Avg merge
- 1h 48m
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pluginsGLPI/addressing
-
Improvements Open
Difficulty 5/5 Over a week Newbie friendliness 25/100
pluginsGLPI/addressing#105 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
pluginsGLPI/addressing#77 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
pluginsGLPI/addressing#53 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
pluginsGLPI/addressing#51 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
pluginsGLPI/addressing#15 · 1 comment ·
All issues in pluginsGLPI/addressing
Similar issues
-
Solved site promotion gate fails on runner PHP patch drift (expects 8.2.33, runner installs 8.2.34) Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Automattic/blocks-engine#2161 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/static-site-importer#1824 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
0. Needs triage 35-feedback bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100