Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Unmanaged Devices don't appear in IP report

Aperta
#82 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
42/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
php, sql
Ambito
backend, databases

Direzione di ricerca

Start in inc/addressing.class.php, focusing on the $types handling for Unmanaged Devices and the generated IP report query. Reproduce the report with debug mode enabled and inspect the reported ambiguous ip grouping warning. Done means Unmanaged Devices appear in the IP report without the SQL warning.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

GLPI 10.0.10
IP Adressing 3.0.2
Debian bookworm

I would like to make appear in IP reports Unmanaged Devices discovered by GLPI NetDiscovery tasks, to have a complete view of used IPs in a network.
inc/addressing.class.php contains a code section dedicated to Unmanaged Devices, but $types does not contain Unmanaged.
Unmanaged Devices appear properly in report if I add Unmanaged in $types.
But debug mode shows following message.
What is wrong ?

SQL Warnings: 1052: Column 'ip' in group statement is ambiguous in query "SELECT port.id, 'NetworkEquipment' AS itemtype, dev.id AS on_device, dev.name AS dname, '' AS pname, glpi_ipaddresses.name as ip, port.mac, dev.users_id, INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_networkequipments dev ON (port.items_id = dev.id AND port.itemtype = 'NetworkEquipment') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND dev.is_deleted = 0 AND dev.is_template = 0 AND ( dev.entities_id = '3' ) UNION (SELECT port.id, 'Computer' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,dev.users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_computers dev ON (port.items_id = dev.id AND port.itemtype = 'Computer') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'NetworkEquipment' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,dev.users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_networkequipments dev ON (port.items_id = dev.id AND port.itemtype = 'NetworkEquipment') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Peripheral' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,dev.users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_peripherals dev ON (port.items_id = dev.id AND port.itemtype = 'Peripheral') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Phone' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,dev.users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_phones dev ON (port.items_id = dev.id AND port.itemtype = 'Phone') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Printer' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,dev.users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_printers dev ON (port.items_id = dev.id AND port.itemtype = 'Printer') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Enclosure' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,0 AS users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_enclosures dev ON (port.items_id = dev.id AND port.itemtype = 'Enclosure') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'PDU' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,0 AS users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_pdus dev ON (port.items_id = dev.id AND port.itemtype = 'PDU') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' AND dev.is_template = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Cluster' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,0 AS users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_clusters dev ON (port.items_id = dev.id AND port.itemtype = 'Cluster') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' GROUP BY ip, port.mac ORDER BY ipnum) UNION (SELECT port.id, 'Unmanaged' AS itemtype, port.items_id, dev.name AS dname, port.name AS pname, glpi_ipaddresses.name as ip, port.mac ,0 AS users_id , INET_ATON(glpi_ipaddresses.name) AS ipnum FROM glpi_networkports port LEFT JOIN glpi_unmanageds dev ON (port.items_id = dev.id AND port.itemtype = 'Unmanaged') LEFT JOIN glpi_networknames ON (port.id = glpi_networknames.items_id) LEFT JOIN glpi_ipaddresses ON (glpi_ipaddresses.items_id = glpi_networknames.id) WHERE (glpi_ipaddresses.name IS NOT NULL AND glpi_ipaddresses.name != '') AND glpi_ipaddresses.version LIKE 4 AND (INET_ATON(glpi_ipaddresses.name) BETWEEN '168625409' AND '168625662') AND ( dev.entities_id = '3' ) AND dev.is_deleted = '0' GROUP BY ip, port.mac ORDER BY ipnum)"

Lingua principale
PHP
Stelle
43
Fork
24
Merge medio
1h 26m
PR unite (30g)
6

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di pluginsGLPI/addressing

Tutte le issue di pluginsGLPI/addressing

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.