Export default module in plotly-renderer.js

Open
#4,789 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

Assessment

This issue has not been assessed yet.

Description

feature P3

Hi There!

We are using jupyter-plotly to support plotly plots in mystmd's web themes to enable people publishing jupyter notebooks with plotly outputs to have their plots displayed and active in their websites.

To achieve this we currently have to patch plotly-renderer.js to add a default export. See: https://github.com/jupyter-book/myst-theme/blob/3a1b70b6f2a6b827effb60891f0e693c9bf65e05/patches/jupyterlab-plotly%2B5.18.0.patch

We'd love to avoid the patch but appreciate the patch we are doing might be good for our case but break other things. If you have advice on how to change our usage, which is pretty simple (see: https://github.com/jupyter-book/myst-theme/blob/3a1b70b6f2a6b827effb60891f0e693c9bf65e05/packages/jupyter/src/plotly.ts#L40) without the need for any changes orthe patch, we'd love to go that way too.

Thanks!

Dominant language
Python
Stars
18.8k
Forks
2.8k
Avg merge
16h 26m
Merged PRs (30d)
21

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from plotly/plotly.py

All issues in plotly/plotly.py

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.