Remove `@types/plotly.js` dependency

Open Beginner friendly
#5,740 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
javascript
Domain
build-system

Research direction

Start with the dev dependencies in js/package.json, then search the JavaScript code for imports or references to @types/plotly.js. Check whether plotly.js 4.0.0's bundled types cover those uses. Done means removing the redundant dependency without breaking the JavaScript checks or type usage.

Written by the indexing model from the issue text.

Description

P3 size: 1 task

@types/plotly.js (the DefinitelyTyped types for plotly.js) is listed as a dev dependency in js/package.json.

As of plotly.js 4.0.0, types are included in plotly.js itself (see https://github.com/plotly/plotly.js/pull/7680), so we can probably remove the @types/plotly.js dependency. I haven't looked into how the types are actually used in the code.

Dominant language
Python
Stars
18.8k
Forks
2.8k
Avg merge
16h 26m
Merged PRs (30d)
21

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from plotly/plotly.py

All issues in plotly/plotly.py

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.