Modal accessibility issues on close button
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- accessibility, frontend
Research direction
Start by reading pattern.js and its modal default template. Confirm how the close control is rendered and whether the requested button, ARIA attributes, and screen-reader-only text belong there. Done means the generic template provides an accessible close control, with the issue's template-override question also answered.
Written by the indexing model from the issue text.
Description
The close "button" is a link (<a>), and it'd be better to have a <button>.
I'd like to add ARIA attributes and place inside of it some elements like a with the icon (×) hidden from screen readers and another one with some representative text (i.e: "CLOSE") shown only to screen reader (CSS class: sr-only).
This changes should be generic enough to be added to the modal default template in pattern.js.
So, I could implement this and submit a PR if agree.
Otherwise, how can I override pattern.js file in order to change the template? I can't override default template attribute in the object from the TAL template when calling the pattern, so how can I fix this?
- Dominant language
- JavaScript
- Stars
- 57
- Forks
- 103
- Avg merge
- 4h 35m
- Merged PRs (30d)
- 11
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from plone/mockup
-
wrong description text in the tinymce image insert modal dialogMay be free again @anya-xcode claimed this 445 days ago, and no pull request is open. Open
Difficulty 1/5 Under an hour Newbie friendliness 62/100
plone/mockup#1489 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
plone/mockup#1483 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
plone/mockup#1402 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
plone/mockup#1373 · 3 comments ·
Maintainers usually reply within 1 day
-
04 type: enhancement
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
HarperFast/harper#3275 ·
Maintainers usually reply within 1 day
-
bug release:v5.34
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Jason-Vaughan/TangleClaw#2504 ·
Maintainers usually reply within 1 day
-
bug status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
mastra-ai/mastra#27538 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
Foundryborne/daggerheart#2497 ·
Maintainers usually reply within 1 day