`pat-upload` event when all uploads are completed
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- Half a day
- Newbie friendliness
- 45/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start by checking the pat-upload documentation and searching the repository for uploadAllCompleted and queuecomplete usages. Document that uploadAllCompleted fires after each successful file, and show how to configure Dropzone's queuecomplete event through pat-upload; confirm the documented option matches the available behavior.
Written by the indexing model from the issue text.
Description
I though that uploadAllCompleted event tells me, that all uploads are completed -> wrong 🤔
Since this event gets triggered on Dropzone.success, its fired after each uploaded file. The correct event would be Dropzone.queuecomplete. But with this event you do not have the data of the uploaded files. This needs investigation who uses uploadAllComplete and how ... currently greping mockup shows, that its not used at all, since tinyce now has the contentbrowser.
Mainly this is "just" a documentation issue, because all pat-uploadoptions get injected into Dropzone so you can simply use data-pat-upload="queuecomplete: my_complete_function" and register it as window.my_complete_function somehwere in your code.
- Dominant language
- JavaScript
- Stars
- 57
- Forks
- 103
- Avg merge
- 6d 15h
- Merged PRs (30d)
- 5
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from plone/mockup
-
wrong description text in the tinymce image insert modal dialogMay be free again @anya-xcode claimed this 452 days ago, and no pull request is open. Open
Difficulty 1/5 Under an hour Newbie friendliness 62/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
-
04 type: enhancement
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Similar issues
-
Link Checker ReportOpenautomated issue report
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
microsoft/playwright#43640 ·
Maintainers usually reply within 1 day
-
✏️ Editing - Tags
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
openfoodfacts/openfoodfacts-server#15127 ·
Maintainers usually reply within 1 day
-
enhancement good first issue hacktoberfest help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Andbal23/dynamic-music-pill#195 ·
Maintainers usually reply within 1 day