Non-unique ids in Theming Controlpanel
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start by locating the Theming Controlpanel, also called Theme settings, and the code that generates its two levels of nav elements and anchors. Reproduce the duplicate IDs and href targets shown in the issue; done means every generated ID and corresponding anchor is unique and nested headings remain directly addressable by URL.
Written by the indexing model from the issue text.
Description
The "Theming Controlpanel" (aka. "Theme settings") has two levels of nav-elements with non-unique ids.
-
- level:
autotoc-item-autotoc-0,autotoc-item-autotoc-1
- level:
-
- level:
autotoc-item-autotoc-0,autotoc-item-autotoc-1,autotoc-item-autotoc-2
- level:
The given anchors are also non-unique (see href attributes). It is not possible to properly access the elements via a url with anchor.
I'd suggest to change the 2. level ids to something like autotoc-item-autotoc-1-0, autotoc-item-autotoc-1-1, autotoc-item-autotoc-1-2
In which repository should I post an issue?
For more details and an image see this issue and the comments.
- Dominant language
- JavaScript
- Stars
- 57
- Forks
- 103
- Avg merge
- 6d 15h
- Merged PRs (30d)
- 5
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from plone/mockup
-
wrong description text in the tinymce image insert modal dialogMay be free again @anya-xcode claimed this 452 days ago, and no pull request is open. Open
Difficulty 1/5 Under an hour Newbie friendliness 62/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
-
04 type: enhancement
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Add: Story4 CZOpencheck:passed logos:add
Difficulty 1/5 Under an hour Newbie friendliness 70/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
adobe/helix-shared#1310 ·
Maintainers usually reply within 1 day
-
[workshop-sim] Improve: Strengthen practice and checkpoints in Step 05 (What Are Agentic Workflows?)Openfeedback simulation workshop
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
githubnext/gh-aw-workshop#4972 ·
Maintainers usually reply within 1 day
-
agent/ci-maintainer ci good first issue help wanted stage/010-actionable
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
cncf/endusers#1890 · 3 comments ·
Maintainers usually reply within 1 day