Check in the production e2e test that deleting a run deletes its artifacts

Open Beginner friendly
#310 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
aws, django, docker, python
Domain
testing-qa

Research direction

Start with secondshift/runs/signals.py, where the delete path calls delete_output for each stored file after the delete commits, then read scripts/production_e2e/drive.py to see how the existing S3 and local-file checks are structured. Add a step that deletes a finished run and then confirms its objects are gone from the RustFS bucket while other runs' objects remain, and run it in both storage modes. Done means the check passes in both modes and fails if the artifacts are left behind.

Written by the indexing model from the issue text.

Description

area: deployment

Problem

The production e2e test checks that run artifacts are written to S3 and read back, including after a restart and a restore. It does not check that they are deleted.

Artifacts are deleted when their run is deleted. secondshift/runs/signals.py calls delete_output for each stored file after the delete commits. If that breaks against a real S3 store, files pile up in the bucket and nothing notices.

Proposal

Add a check to scripts/production_e2e/drive.py: delete a finished run, then confirm its objects are gone from the RustFS bucket and the other runs' objects are still there. Run it in both storage modes the test already covers (S3 and local files).

Follow-up to #40.

Dominant language
Python
Stars
1
Forks
1
Avg merge
1h 9m
Merged PRs (30d)
322

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from piotrekno1/second-shift

All issues in piotrekno1/second-shift

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.