[Bug]: Mobile terminal paste button is hidden off-screen in the scrolling toolbar
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react-native, typescript
- Domain
- mobile
Research direction
Start with apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx and inspect how the accessory toolbar and ComposerToolbarButton are laid out. Check how the existing keyboard dismissal button is positioned, then consider how the paste action can stay visible on a phone-width screen. Done means users can find and use Paste without scrolling the toolbar.
Written by the indexing model from the issue text.
Description
Before submitting
- I searched existing issues and did not find a duplicate.
- I included enough detail to reproduce or investigate the problem.
Area
apps/mobile
Steps to reproduce
- Open a thread's terminal in the mobile app on a phone.
- Tap the terminal so the keyboard and the terminal accessory toolbar appear.
- Look for a way to paste the phone's clipboard.
Expected behavior
Paste is visible without scrolling. Pasting a copied command is one of the most common things to do in a mobile terminal.
Actual behavior
paste is the 10th button in the horizontally scrolling accessory toolbar (↑ ↓ ← → esc ctrl alt tab paste clear ~ | / -). On a phone-width screen it sits past the visible area, so it is easy to never find. Nothing makes it obvious that the toolbar scrolls: the right-edge fade is subtle, and the visible buttons fill the row, so it reads as a complete set of keys. I used the terminal for a while without realizing there were more buttons past the edge. Long-pressing the terminal does not offer Paste either (the iOS terminal view has no edit menu), so it looks like pasting is not possible at all.
#16299 / #21398 fixed the same kind of problem for the arrow keys by moving them to the front, which pushed paste further right.
Impact
Minor bug or occasional failure
Version or commit
main @ 24c80f34a1
Environment
iOS, T3 Code mobile app
Workaround
Scroll the accessory toolbar to the right to find paste.
Possible fix
Pin paste as an icon button outside the scroller, next to the existing "Dismiss keyboard" button (ComposerToolbarButton with icon, e.g. doc.on.clipboard / content_paste) in apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx. Happy to send a PR if that direction sounds right.
- Dominant language
- TypeScript
- Stars
- 24.8k
- Forks
- 6.4k
- Avg merge
- 4h 29m
- Merged PRs (30d)
- 305
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pingdotgg/t3code
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
[Bug]: Sidebar "Failed" badge does not clear when the session is opened (unlike "Done")Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
[Bug]: Assistant message hover timestamp missing while a command is still runningPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 87/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
All issues in pingdotgg/t3code
Similar issues
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
apex-dev-tools/apex-log-parser#199 ·
Maintainers usually reply within 1 day
-
area/frontend/library-panels automated-triage type/bug type/ux
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PostHog/posthog.com#21607 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
ajv-validator/ajv#2689 ·
-
[Bug]: IME confirmation Enter can submit the SSH port-forward dialogPossibly taken @seijikohara claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day