[Bug]: Add to agent silently discards an earlier unsent PR diff question
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start with the composer handoff in apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx and the replacement logic in apps/web/src/components/pullRequest/pullRequestDetail.logic.ts. Read the related test in apps/web/src/components/pullRequest/pullRequestDetail.logic.test.ts, then update coverage so repeated Add to agent actions preserve earlier unsent questions and line citations.
Written by the indexing model from the issue text.
Description
Before submitting
- I searched existing issues and did not find a duplicate.
- I included enough detail to reproduce or investigate the problem.
Area
apps/web
Steps to reproduce
- In a thread linked to a PR, open its Code tab.
- Select a diff line, enter a question, and click Add to agent. Do not send the composer.
- Repeat on a different line with a second question.
- Inspect the composer.
Expected behavior
I expected Add to agent to keep both unsent questions and their line citations.
Actual behavior
After the second action, only its line citation remains. The first unedited question is also replaced. The public [composer handoff](https://github.com/pingdotgg/t3code/blob/451afcb22d93f06cb24f9bc16703404564952553/apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx#L1074-L1100) uses [replacement logic](https://github.com/pingdotgg/t3code/blob/451afcb22d93f06cb24f9bc16703404564952553/apps/web/src/components/pullRequest/pullRequestDetail.logic.ts#L659-L721), and its [test](https://github.com/pingdotgg/t3code/blob/451afcb22d93f06cb24f9bc16703404564952553/apps/web/src/components/pullRequest/pullRequestDetail.logic.test.ts#L1209-L1215) expects the earlier citation to be removed.
Impact
Cosmetic issue
Version or commit
No response
Environment
No response
Logs or stack traces
Screenshots, recordings, or supporting files
No response
Workaround
No response
- Dominant language
- TypeScript
- Stars
- 24.8k
- Forks
- 6.4k
- Avg merge
- 8h 34m
- Merged PRs (30d)
- 243
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pingdotgg/t3code
-
bug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
pingdotgg/t3code#16859 · 1 comment ·
Maintainers usually reply within 1 day
-
bug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pingdotgg/t3code#16822 · 1 comment ·
Maintainers usually reply within 1 day
-
bug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pingdotgg/t3code#16821 · 1 comment ·
Maintainers usually reply within 1 day
-
bug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
pingdotgg/t3code#16810 · 2 comments ·
Maintainers usually reply within 1 day
-
[Bug]: Antigravity turns fail on NixOS: embedded Python can't verify TLS (empty CA store) -> 502Openbug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
pingdotgg/t3code#16742 · 1 comment ·
Maintainers usually reply within 1 day
All issues in pingdotgg/t3code
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Small-tailqwq/dsh-deep-whale#187 ·
Maintainers usually reply within 1 day
-
Tela Marca manda conferir o campo "Razão social", que em Portugal se chama "Denominação social"Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
melgarafael/DeskcommCRM#2503 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
0x80/isolate-package#218 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
area/web interface
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
mastodon/mastodon#40924 · 1 comment ·
Maintainers usually reply within 1 day