[Bug]: Default-ref confirmation changes content while closing
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 86/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start in apps/web/src/components/GitActionsControl.tsx at the pendingDefaultBranchAction state and the dialog rendering around lines 2008-2039. Read apps/web/src/components/ui/dialog-styles.ts to understand the 200 ms exit transition. Reproduce dismissal with Abort, the close button, and Escape; done means the original title, description, and button labels remain unchanged until the dialog fully closes.
Written by the indexing model from the issue text.
Description
Before submitting
- I searched existing issues and did not find a duplicate.
- I included enough detail to reproduce or investigate the problem.
Area
apps/web (also visible in the desktop app, which uses the web UI)
Steps to reproduce
- Open a git-backed thread on the repository's default ref, with working-tree changes and a configured remote.
- Click the top-right Commit & push action so the Commit & push to default ref? confirmation opens.
- Dismiss the confirmation with Abort, the close button, or Escape.
- Watch the dialog during its closing animation.
Expected behavior
The title, description, and button labels stay the same until the dialog has fully closed.
Actual behavior
Before the dialog disappears, its content changes to shorter fallback text. The title becomes Run action on default branch?, the description disappears, and the primary action label becomes Continue. This makes the dialog visibly shrink or jump during its exit animation.
Impact
Cosmetic issue.
Version or commit
Reported on 0.0.43-nightly.20260926.2282. The same state flow is present in source at 5f878d2a85807618a4c8571cdef5daa3124672d6.
Environment
T3 Code local instance on Linux (CachyOS). Exact client surface was not confirmed.
Investigation
The dialog's open prop depends on pendingDefaultBranchAction !== null. Dismissing it immediately sets that state to null, which also makes pendingDefaultBranchActionCopy null. The rendered title, description, and button then change to their fallback values while the popup remains mounted for its 200 ms exit transition.
Relevant source: GitActionsControl.tsx, dialog rendering, and exit transition.
I confirmed this state path in source, but could not capture a browser recording in this environment.
- Dominant language
- TypeScript
- Stars
- 23.6k
- Forks
- 6.1k
- Avg merge
- 10h 20m
- Merged PRs (30d)
- 309
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pingdotgg/t3code
-
bug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
pingdotgg/t3code#14452 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
All issues in pingdotgg/t3code
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
solana-foundation/program-examples#747 · 1 comment ·
Maintainers usually reply within 9 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
remotion-dev/remotion#11847 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
openwatersio/slackwater#355 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
melgarafael/DeskcommCRM#1998 · 3 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
webarkit/jsfeatNext#225 ·
Maintainers usually reply within 1 day