Check if override method does not rename parameters
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Open the two linked PHPStan reproductions and compare the override methods, focusing on the first parameter and the reported line 12. Trace the strict-rule check that handles method overrides, then confirm that the reproduction emits an error when the parameter is renamed.
Written by the indexing model from the issue text.
Description
repro: https://phpstan.org/r/1c91414c-7a03-437c-976a-95a28d07f919 and https://phpstan.org/r/e2b66886-71db-4a33-9c17-aee3c1f67b7d
to improve override methods checks and make refactoring/updates safer
expected result: l12 in the repro should emit phpstan error for the 1st parameter
- Dominant language
- PHP
- Stars
- 711
- Forks
- 62
- Avg merge
- 35m
- Merged PRs (30d)
- 4
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phpstan/phpstan-strict-rules
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
phpstan/phpstan-strict-rules#317 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
phpstan/phpstan-strict-rules#316 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
phpstan/phpstan-strict-rules#298 · 2 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
phpstan/phpstan-strict-rules#289 · 1 comment ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
phpstan/phpstan-strict-rules#283 · 6 comments ·
All issues in phpstan/phpstan-strict-rules
Similar issues
-
sync-en
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 3 days
-
Form
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
symfony/symfony-docs#23159 ·
Maintainers usually reply within 3 days
-
bug component: bulk editor support
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Yoast/wordpress-seo#23669 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
php/frankenphp#2688 ·
Maintainers usually reply within 1 day