Handle blank proxy environment variables

Open
#80 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
elixir
Domain
backend

Research direction

Start with proxy_for_scheme/1, which the issue identifies as a possible place to handle blank proxy variables, then trace how Esbuild.NpmRegistry.fetch_package/2 and proxy_auth/1 use the result. Treat blank HTTP_PROXY and HTTPS_PROXY values as unset; done when those functions no longer fail with blank values and the existing proxy behavior remains intact.

Written by the indexing model from the issue text.

Description

&Esbuild.NpmRegistry.fetch_package/2 and proxy_auth/1 will fail if HTTP(S)_PROXY environment variables are set blank.

Blank proxy environment variables should be handled as if they are not set.

Maybe blank environment variables should be checked for in proxy_for_scheme/1

Dominant language
Elixir
Stars
276
Forks
42
Avg merge
1m
Merged PRs (30d)
1

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phoenixframework/esbuild

All issues in phoenixframework/esbuild

Similar issues

More Elixir issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.