Don't step SpeechSynthesisAnnouncer if it is disabled?
Nobody has claimed this yet.
Assessment
This issue has not been assessed yet.
Description
We might be doing unecessary operations when Voicing/SpeechSynthesis is not enabled by stepping in this case.
The UtteranceQueue returns in step if not enabled. Maybe we can/should do the same for SpeechSynthesisAnnouncer. The UtteranceQueue used to step the SpeechSynthesisAnnouncer, so this actually seems like a safe thing to do after we moved the announcer.step call out of the UTteranceQueue in #71.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phetsims/utterance-queue
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
phetsims/utterance-queue#125 ·
-
phetsims/utterance-queue#122 · 2 comments · 1 assignee ·
-
phetsims/utterance-queue#121 · 1 assignee ·
-
Remove addToFront Open
phetsims/utterance-queue#120 · 1 assignee ·
-
dev:voicing type:i18n
Difficulty 5/5 Over a week Newbie friendliness 25/100
phetsims/utterance-queue#119 · 1 comment ·
All issues in phetsims/utterance-queue
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ontola/atomic-server#1625 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
melgarafael/DeskcommCRM#1451 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
bug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bot:ai-assisted component:compact-js status:untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
midnightntwrk/midnight-sdk#403 ·