Can UtteranceQueue be immutable and made private?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- accessibility
Research direction
Start by reading the UtteranceQueue API and the referenced Voicing.ts code at lines 463-466 to understand how alerts are currently mutated and queued. Define the intended immutable queue behavior and replacement for constructing public Utterances; done requires an agreed API and corresponding implementation scope.
Written by the indexing model from the issue text.
Description
We are finding it difficult to use Utterance. It is confusing that the alert can be mutated, and is often mutated internally like 840669961a5f54e01d209486653ed73/js/accessibility/voicing/Voicing.ts#L463-L466 wich is difficult to work with.
Also, can we get rid of Utterances as a public data structure? It seems like we should not need to construct Utterances to add to the queue. Metadata/options are reasonable but creating a new Utterance adds extra boilerplate.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phetsims/utterance-queue
-
Remote service voices are causing problemsMay be free again @jessegreenberg claimed this 472 days ago, and no pull request is open. Open
phetsims/utterance-queue#122 · 2 comments · 1 assignee ·
-
Rename UtteranceQueue.addToBackMay be free again @jessegreenberg claimed this 499 days ago, and no pull request is open. Open
phetsims/utterance-queue#121 · 1 assignee ·
-
Remove addToFrontMay be free again @jessegreenberg claimed this 499 days ago, and no pull request is open. Open
phetsims/utterance-queue#120 · 1 assignee ·
-
dev:voicing type:i18n
Difficulty 5/5 Over a week Newbie friendliness 25/100
phetsims/utterance-queue#119 · 1 comment ·
-
dev:voicing
Difficulty 4/5 3-5 days Newbie friendliness 25/100
phetsims/utterance-queue#92 · 4 comments ·
All issues in phetsims/utterance-queue
Similar issues
-
bug HemiStake
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
hemilabs/ui-monorepo#2413 ·
Maintainers usually reply within 1 day
-
component/ui framework/react kind/bug language/javascript
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
meshery/meshery#22216 · 3 comments ·
Maintainers usually reply within 1 day
-
type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
paperclipai/paperclip#14982 ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
lingdojo/kana-dojo#31515 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day