Should TransitionNode set focus when it completes a transition?
@jessegreenberg is already working on this.
Since May 29, 2021.
Assessment
This issue has not been assessed yet.
Description
For https://github.com/phetsims/fourier-making-waves/issues/53, and as noted in https://github.com/phetsims/vegas/issues/90#issuecomment-850636738:
So in the meantime, I’ll modify TransitionNode to move focus to the first element in pDomOrder for the Node that it has transitioned to. For Fourier, that’s the Back button for a level, and the “Level 1” button for the level-selection UI.
If a Node has no pDomOrder, TransitionNode will do nothing.
@jessegreenberg FYI.
- Dominant language
- TypeScript
- Stars
- 2
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phetsims/twixt
-
Readme makes it seem like twixt is a work in progressMay be free again @brettfiedler claimed this 818 days ago, and no pull request is open. Openbeginner-friendly good-first-issue type:documentation type:open-source-ecosystem
-
priority:5-deferred type:bug
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
why is Easing a type?May be free again @jonathanolson claimed this 2757 days ago, and no pull request is open. Opendev:code-review type:question
-
add unit tests for EasingMay be free again @jonathanolson claimed this 2098 days ago, and no pull request is open. Opendev:enhancement
-
TransitionNode fails if options.content is not providedMay be free again @jonathanolson claimed this 3073 days ago, and no pull request is open. Opendev:code-review type:bug
Similar issues
-
calcite-ui-icons enhancement impact - p3 - not time sensitive needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Esri/calcite-design-system#15467 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
diegosouzapw/OmniRoute#18390 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
guilhermerodz/input-otp#157 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
davidjerleke/embla-carousel#1414 ·
Maintainers usually reply within 4 days